Improvements for associative_scan - lifted_args for combine_mode='generic' #134921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134921
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d298561 with merge base 3c7d9d6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
colesbury
added
the
triaged
bohnstingl
force-pushed
the
generic_associative_scan_5
branch
from
f1ac6c8 to
39cdb4d
Compare
bohnstingl
force-pushed
the
generic_associative_scan_5
branch
from
39cdb4d to
20927b8
Compare
Collaborator
Author
|
@pytorchbot label "topic: not user facing" |
Added additional testcases
bohnstingl
force-pushed
the
generic_associative_scan_5
branch
from
20927b8 to
d298561
Compare
Collaborator
Author
|
Closing this PR, because the lifted arguments are implemented in an alternative PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a series of improvements for associative_scan and implements lifted arguments for the
combine_fn, if thecombine_mode='generic'is used.@ydwu4
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov @rec