Rewrite unsafe_remove_auto_functionalized_pass using decompose_auto_functionalized
#134831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
laithsakka
requested review from
angelayi,
avikchaudhuri,
tugsbayasgalan,
ydwu4 and
zhxchen17
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134831
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 29f2c60 with merge base 416a789 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
laithsakka
changed the title
laithsakka
changed the title
laithsakka
changed the title
unsafe_remove_auto_functionalized_pass using decompose_auto_functionalized
This was referenced Aug 30, 2024
zou3519
approved these changes
Aug 30, 2024
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 3, 2024
title + use `with torch.library._scoped_library as lib` when needed. Pull Request resolved: #134834 Approved by: https://github.com/zou3519 ghstack dependencies: #134831
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
…o_functionalized` (pytorch#134831) `unsafe_remove_auto_functionalized_pass` can be written as using `decompose_auto_functionalized`, this way we do not have to update it each time we do a change to `auto_functionalize` (Ex pytorch#134409) , and we avoid duplicate logics implemented in two different ways. Pull Request resolved: pytorch#134831 Approved by: https://github.com/zou3519
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
title + use `with torch.library._scoped_library as lib` when needed. Pull Request resolved: pytorch#134834 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#134831
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
unsafe_remove_auto_functionalized_passusingdecompose_auto_functionalized#134831unsafe_remove_auto_functionalized_passcan be written as usingdecompose_auto_functionalized, this way we do not have to update it each time we do a change toauto_functionalize(Ex #134409) , and we avoid duplicate logics implemented in two different ways.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang