Improve opcheck docs. #134692
Closed
Improve opcheck docs. #134692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #134119 From user feedback, it's difficult to understand what the tests do. We clarify the docs more. [ghstack-poisoned]
This was referenced Aug 28, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134692
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8e3864e with merge base 55236d0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
albanD
approved these changes
Aug 28, 2024
torch/library.py
Outdated
| - test_schema: if the operator's schema is correct. | ||
| - test_autograd_registration: if autograd was registered correctly. | ||
| - test_schema: We test that the schema matches the implementation of |
Collaborator
There was a problem hiding this comment.
Suggested change
| - test_schema: We test that the schema matches the implementation of | |
| - test_schema: If the schema matches the implementation of |
For consistency with the other entries below :)
| specifies that we return a new Tensor, then we check that the | ||
| implementation returns a new Tensor (instead of an existing one or | ||
| a view of an existing one). | ||
| - test_autograd_registration: If the operator supports training |
Collaborator
There was a problem hiding this comment.
I was almost expecting one of these entries to use gradcheck to test gradients. But I only see the aot_dispatch below checking matching eager vs compile.
Is that expected?
Contributor
Author
There was a problem hiding this comment.
Yes, we don't run gradcheck. opcheck is to check that the "registrations were correct", we recommend the user use gradcheck for their gradients.
Fixes #134119 From user feedback, it's difficult to understand what the tests do. We clarify the docs more. [ghstack-poisoned]
Pavelanln
pushed a commit
to Pavelanln/Coppy
that referenced
this pull request
Sep 18, 2024
Fixes pytorch/pytorch#134119 From user feedback, it's difficult to understand what the tests do. We clarify the docs more. ghstack-source-id: aad726b Pull Request resolved: pytorch/pytorch#134692
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
Fixes pytorch#134119 From user feedback, it's difficult to understand what the tests do. We clarify the docs more. Pull Request resolved: pytorch#134692 Approved by: https://github.com/albanD ghstack dependencies: pytorch#134466, pytorch#134490, pytorch#134491, pytorch#134690
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
Fixes pytorch#134278 Test Plan: - tested locally Pull Request resolved: pytorch#134688 Approved by: https://github.com/yushangdi ghstack dependencies: pytorch#134466, pytorch#134490, pytorch#134491, pytorch#134690, pytorch#134692
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixes #134119
From user feedback, it's difficult to understand what the tests do. We
clarify the docs more.