[CD] Fix docker builds by installing setuptools #134595
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134595
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 12acb4b with merge base 13114da ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kit1980
approved these changes
Aug 27, 2024
seemethere
approved these changes
Aug 27, 2024
malfet
approved these changes
Aug 27, 2024
Contributor
malfet
left a comment
malfet
left a comment
There was a problem hiding this comment.
LGTM, but should we install it only for 3.12+?
malfet
reviewed
Aug 27, 2024
Contributor
Author
|
@pytorchmergebot merge -f "lint and docker builds are successful" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 28, 2024
…134631) Follow up after #134595 Same error happens silently before the error addressed in the above PR (and build continues and builds invalid Docker): ``` #47 457.5 Traceback (most recent call last): #47 457.5 File "<string>", line 1, in <module> #47 457.5 File "/opt/_internal/cpython-3.12.0/lib/python3.12/site-packages/wheel/pep425tags.py", line 3, in <module> #47 457.5 import distutils.util #47 457.5 ModuleNotFoundError: No module named 'distutils' #47 457.5 + local abi_tag= #47 457.5 + ln -s /opt/_internal/cpython-3.12.0 /opt/python/ #47 457.5 + rm -f Python-3.12.0.tgz ``` The fix in #134595 is no longer needed since we will install setuptools right after python installation. Link: https://github.com/pytorch/pytorch/actions/runs/10584642913/job/29329366729#step:6:6041 Pull Request resolved: #134631 Approved by: https://github.com/kit1980
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
Seeing failures like this: ``` pytorch#49 844.6 //build_scripts/manylinux1-check.py:6: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives ..... [python 3/3] RUN bash build_scripts/build.sh && rm -r build_scripts: 846.9 ...it did, yay. 846.9 + for PYTHON in '/opt/python/*/bin/python' 846.9 + /opt/python/cpython-3.12.0/bin/python build_scripts/manylinux1-check.py 847.0 Traceback (most recent call last): 847.0 File "//build_scripts/manylinux1-check.py", line 55, in <module> 847.0 if is_manylinux1_compatible(): 847.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^ 847.0 File "//build_scripts/manylinux1-check.py", line 6, in is_manylinux1_compatible 847.0 from distutils.util import get_platform 847.0 ModuleNotFoundError: No module named 'distutils' ------ ``` PR: pytorch#134455 Pull Request resolved: pytorch#134595 Approved by: https://github.com/kit1980, https://github.com/seemethere, https://github.com/malfet
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
…ytorch#134631) Follow up after pytorch#134595 Same error happens silently before the error addressed in the above PR (and build continues and builds invalid Docker): ``` pytorch#47 457.5 Traceback (most recent call last): pytorch#47 457.5 File "<string>", line 1, in <module> pytorch#47 457.5 File "/opt/_internal/cpython-3.12.0/lib/python3.12/site-packages/wheel/pep425tags.py", line 3, in <module> pytorch#47 457.5 import distutils.util pytorch#47 457.5 ModuleNotFoundError: No module named 'distutils' pytorch#47 457.5 + local abi_tag= pytorch#47 457.5 + ln -s /opt/_internal/cpython-3.12.0 /opt/python/ pytorch#47 457.5 + rm -f Python-3.12.0.tgz ``` The fix in pytorch#134595 is no longer needed since we will install setuptools right after python installation. Link: https://github.com/pytorch/pytorch/actions/runs/10584642913/job/29329366729#step:6:6041 Pull Request resolved: pytorch#134631 Approved by: https://github.com/kit1980
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing failures like this:
PR: #134455