[1/N] Fix clang-tidy warnings in torch/csrc/api/ #134545
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134545
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (1 Unrelated Failure)As of commit ae2ade6 with merge base 77fba0c ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cyyever
changed the title
cyyever
force-pushed
the
tidy_api
branch
2 times, most recently
from
c6f40a5 to
073a8d0
Compare
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
Sounds good.
Any lintrunner update to make sure this keeps clean?
albanD
added
the
triaged
This part of code is rarely updated. No plan to update lintrunner with the afraid that it may eventually take too long time to complete. |
cyyever
requested review from
albanD and
ezyang
and removed request for
Skylion007
There was a problem hiding this comment.
Aren't all these changes BC-breaking changes for our public C++ API?
There was a problem hiding this comment.
A more restrictive constraint is applied to the parameters, the semantics are not changed.
cyyever
force-pushed
the
tidy_api
branch
2 times, most recently
from
bb5f034 to
1010901
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / win-vs2019-cpu-py3 / test (default, 1, 3, lf.windows.4xlarge.nonephemeral) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 1 checks: trunk / win-vs2019-cpu-py3 / test (default, 1, 3, lf.windows.4xlarge.nonephemeral) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#134545 Approved by: https://github.com/ezyang
Follows #134545 Pull Request resolved: #136998 Approved by: https://github.com/ezyang
6 participants
Fixes #ISSUE_NUMBER