[Release Only] Disable flaky failing tests in release. Pin optree. Pin sympy #134489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134489
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit 46f7c5c with merge base b66e3f0 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kit1980
approved these changes
Aug 26, 2024
Collaborator
|
xla change lgtm too |
atalman
changed the title
Sympy 1.13.2 release yesterday, and it results in test failures on windows and mac https://hud.pytorch.org/hud/pytorch/pytorch/454713fe9d11c3b70c28f1aaba74f5158f92d1ec/1?per_page=100 Hopefully these are the places it needs to get pinned Pull Request resolved: pytorch#133235 Approved by: https://github.com/atalman, https://github.com/ZainRizvi
atalman
changed the title
This reverts commit 864cd32. Revert "Pin sympy to 1.13.1 (pytorch#133235)" This reverts commit cf77a5e. pin sympy win test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optree==0.11.0cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @rec