Skip to content

Conversation

@avikchaudhuri
Copy link
Contributor

Summary: Recently #133620 added support for automatic dynamic shapes, where a new enum, DIM, was introduced to provide hints like AUTO and STATIC. This PR is a nominal change where we expose the hints via the existing public Dim API, and remove DIM from the public API. The main motivation is to avoid having users need to import too many things.

Test Plan: existing

Differential Revision: D61807361

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 26, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134484

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 32 Cancelled Jobs

As of commit f9542b1 with merge base 2ba60a1 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61807361

@avikchaudhuri avikchaudhuri added the suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) label Aug 26, 2024
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 26, 2024
@pianpwk
Copy link
Contributor

pianpwk commented Aug 26, 2024

Thank you!

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61807361

avikchaudhuri added a commit to avikchaudhuri/pytorch that referenced this pull request Aug 26, 2024
Summary:
Pull Request resolved: pytorch#134484

Recently pytorch#133620 added support for automatic dynamic shapes, where a new enum, `DIM`, was introduced to provide hints like `AUTO` and `STATIC`. This PR is a nominal change where we expose the hints via the existing public `Dim` API, and remove `DIM` from the public API. The main motivation is to avoid having users need to import too many things.

Test Plan: existing

Reviewed By: angelayi

Differential Revision: D61807361
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61807361

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61807361

avikchaudhuri added a commit to avikchaudhuri/pytorch that referenced this pull request Aug 26, 2024
Summary:
Pull Request resolved: pytorch#134484

Recently pytorch#133620 added support for automatic dynamic shapes, where a new enum, `DIM`, was introduced to provide hints like `AUTO` and `STATIC`. This PR is a nominal change where we expose the hints via the existing public `Dim` API, and remove `DIM` from the public API. The main motivation is to avoid having users need to import too many things.

Test Plan: existing

Reviewed By: angelayi

Differential Revision: D61807361
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61807361

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61807361

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61807361

Summary:
Pull Request resolved: pytorch#134484

Recently pytorch#133620 added support for automatic dynamic shapes, where a new enum, `DIM`, was introduced to provide hints like `AUTO` and `STATIC`. This PR is a nominal change where we expose the hints via the existing public `Dim` API, and remove `DIM` from the public API. The main motivation is to avoid having users need to import too many things.

Test Plan: existing

Reviewed By: angelayi

Differential Revision: D61807361
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61807361

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot
Copy link
Contributor

@pytorchbot revert -m="Diff reverted internally" -c="ghfirst"

This Pull Request has been reverted by a revert inside Meta. To re-land this change, please open another pull request, assign the same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).)

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@avikchaudhuri your PR has been successfully reverted.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

avikchaudhuri added a commit to avikchaudhuri/pytorch that referenced this pull request Aug 28, 2024
Summary:
Pull Request resolved: pytorch#134702

Retry landing pytorch#134484

Test Plan: (see original)

Reviewed By: pianpwk

Differential Revision: D61925860
pytorchmergebot pushed a commit that referenced this pull request Aug 29, 2024
Summary: Retry landing #134484

Test Plan: (see original)

Differential Revision: D61925860

Pull Request resolved: #134702
Approved by: https://github.com/pianpwk
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
Summary: Recently pytorch#133620 added support for automatic dynamic shapes, where a new enum, `DIM`, was introduced to provide hints like `AUTO` and `STATIC`. This PR is a nominal change where we expose the hints via the existing public `Dim` API, and remove `DIM` from the public API. The main motivation is to avoid having users need to import too many things.

Test Plan: existing

Differential Revision: D61807361

Pull Request resolved: pytorch#134484
Approved by: https://github.com/angelayi
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
Summary: Retry landing pytorch#134484

Test Plan: (see original)

Differential Revision: D61925860

Pull Request resolved: pytorch#134702
Approved by: https://github.com/pianpwk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged Reverted suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants