-
Notifications
You must be signed in to change notification settings - Fork 26.3k
hang dim hint constants off Dim #134484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hang dim hint constants off Dim #134484
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D61807361 |
|
Thank you! |
85bb92f to
585d84b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61807361 |
Summary: Pull Request resolved: pytorch#134484 Recently pytorch#133620 added support for automatic dynamic shapes, where a new enum, `DIM`, was introduced to provide hints like `AUTO` and `STATIC`. This PR is a nominal change where we expose the hints via the existing public `Dim` API, and remove `DIM` from the public API. The main motivation is to avoid having users need to import too many things. Test Plan: existing Reviewed By: angelayi Differential Revision: D61807361
|
This pull request was exported from Phabricator. Differential Revision: D61807361 |
585d84b to
f120f53
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61807361 |
Summary: Pull Request resolved: pytorch#134484 Recently pytorch#133620 added support for automatic dynamic shapes, where a new enum, `DIM`, was introduced to provide hints like `AUTO` and `STATIC`. This PR is a nominal change where we expose the hints via the existing public `Dim` API, and remove `DIM` from the public API. The main motivation is to avoid having users need to import too many things. Test Plan: existing Reviewed By: angelayi Differential Revision: D61807361
f120f53 to
d92629c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61807361 |
d92629c to
4417ec9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61807361 |
4417ec9 to
e54fdaf
Compare
e54fdaf to
211c83a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61807361 |
Summary: Pull Request resolved: pytorch#134484 Recently pytorch#133620 added support for automatic dynamic shapes, where a new enum, `DIM`, was introduced to provide hints like `AUTO` and `STATIC`. This PR is a nominal change where we expose the hints via the existing public `Dim` API, and remove `DIM` from the public API. The main motivation is to avoid having users need to import too many things. Test Plan: existing Reviewed By: angelayi Differential Revision: D61807361
|
This pull request was exported from Phabricator. Differential Revision: D61807361 |
211c83a to
f9542b1
Compare
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m="Diff reverted internally" -c="ghfirst" This Pull Request has been reverted by a revert inside Meta. To re-land this change, please open another pull request, assign the same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).) |
|
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit c142af7. Reverted #134484 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](#134484 (comment)))
|
@avikchaudhuri your PR has been successfully reverted. |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
Summary: Pull Request resolved: pytorch#134702 Retry landing pytorch#134484 Test Plan: (see original) Reviewed By: pianpwk Differential Revision: D61925860
Summary: Retry landing #134484 Test Plan: (see original) Differential Revision: D61925860 Pull Request resolved: #134702 Approved by: https://github.com/pianpwk
Summary: Recently pytorch#133620 added support for automatic dynamic shapes, where a new enum, `DIM`, was introduced to provide hints like `AUTO` and `STATIC`. This PR is a nominal change where we expose the hints via the existing public `Dim` API, and remove `DIM` from the public API. The main motivation is to avoid having users need to import too many things. Test Plan: existing Differential Revision: D61807361 Pull Request resolved: pytorch#134484 Approved by: https://github.com/angelayi
This reverts commit c142af7. Reverted pytorch#134484 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](pytorch#134484 (comment)))
Summary: Retry landing pytorch#134484 Test Plan: (see original) Differential Revision: D61925860 Pull Request resolved: pytorch#134702 Approved by: https://github.com/pianpwk
Summary: Recently #133620 added support for automatic dynamic shapes, where a new enum,
DIM, was introduced to provide hints likeAUTOandSTATIC. This PR is a nominal change where we expose the hints via the existing publicDimAPI, and removeDIMfrom the public API. The main motivation is to avoid having users need to import too many things.Test Plan: existing
Differential Revision: D61807361