Skip to content

Correctly specify size of sparse_csr tensors in maskedtensor binary ops #134335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benjaminglass1 wants to merge 5 commits into from
Closed

Correctly specify size of sparse_csr tensors in maskedtensor binary ops #134335

benjaminglass1 wants to merge 5 commits into from

Conversation

@benjaminglass1
Copy link
Collaborator

@benjaminglass1 benjaminglass1 commented Aug 23, 2024 •
edited by pytorch-bot bot
Loading

@benjaminglass1
Update
c3d06e9 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 23, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134335

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 81ac187 with merge base 9012e7a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

benjaminglass1 added a commit that referenced this pull request Aug 23, 2024
@benjaminglass1
Correctly specify size of sparse_csr tensors in maskedtensor binary ops
f57f2fc 
ghstack-source-id: 8742ba7
Pull Request resolved: #134335
@benjaminglass1
Copy link
Collaborator Author

benjaminglass1 commented Aug 23, 2024

These tests appear to have failed because the mask completely masked out one full row of the data arrays, and the sparse_csr_tensor function incorrectly guessed the size as one row less in those cases. This PR specifies the desired size for the output tensor so that these tests will succeed.

@benjaminglass1 benjaminglass1 requested a review from amjames August 23, 2024 15:19
@benjaminglass1
Update
47f472b 
[ghstack-poisoned]
amjames
amjames approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@amjames amjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice catch.

@amjames amjames marked this pull request as ready for review August 23, 2024 20:28
@amjames amjames added the module: sparse Related to torch.sparse label Aug 23, 2024
@amjames amjames requested a review from cpuhrsch August 23, 2024 20:29
@amjames
Copy link
Collaborator

amjames commented Aug 23, 2024

Labeling this as sparse since I couldn't find a better label for MaskedTensor 🤷

@benjaminglass1
Update
f95c81e 
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Aug 23, 2024
@benjaminglass1
Correctly specify size of sparse_csr tensors in maskedtensor binary ops
6495b3f 
ghstack-source-id: 88f7e97
Pull Request resolved: #134335
@benjaminglass1
Copy link
Collaborator Author

benjaminglass1 commented Aug 23, 2024

Fixed the lint error.

@benjaminglass1
Copy link
Collaborator Author

benjaminglass1 commented Sep 5, 2024

@pytorchbot rebase

@benjaminglass1 benjaminglass1 added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 5, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 5, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@benjaminglass1
Update
0319db1 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 5, 2024

Successfully rebased gh/benjaminglass1/5/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/134335)

pytorchmergebot pushed a commit that referenced this pull request Sep 5, 2024
@benjaminglass1
Correctly specify size of sparse_csr tensors in maskedtensor binary ops
2eccad9 
ghstack-source-id: f1b8acb
Pull Request resolved: #134335
@benjaminglass1 benjaminglass1 added the release notes: sparse release notes category label Sep 5, 2024
@benjaminglass1 benjaminglass1 self-assigned this Oct 3, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Dec 2, 2024
@benjaminglass1
Copy link
Collaborator Author

benjaminglass1 commented Dec 2, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 2, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@benjaminglass1
Update
81ac187 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 2, 2024

Successfully rebased gh/benjaminglass1/5/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/134335)

pytorchmergebot pushed a commit that referenced this pull request Dec 2, 2024
@benjaminglass1
Correctly specify size of sparse_csr tensors in maskedtensor binary ops
9f275b6 
ghstack-source-id: 554743b
Pull Request resolved: #134335
@cpuhrsch
Copy link
Contributor

cpuhrsch commented Dec 3, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 3, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@benjaminglass1
Correctly specify size of sparse_csr tensors in maskedtensor binary o…
f85101c 
…ps (pytorch#134335)

Pull Request resolved: pytorch#134335
Approved by: https://github.com/amjames, https://github.com/cpuhrsch
@github-actions github-actions bot deleted the gh/benjaminglass1/5/head branch January 3, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

@amjames amjames amjames approved these changes

Assignees

@benjaminglass1 benjaminglass1

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: sparse Related to torch.sparse open source release notes: sparse release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@benjaminglass1 @amjames @pytorchmergebot @cpuhrsch @pytorchbot