Skip to content

Add XPU backend in check conditions in AdvancedIndex #134072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
majing921201 wants to merge 2 commits into from
Closed

Add XPU backend in check conditions in AdvancedIndex #134072

majing921201 wants to merge 2 commits into from

Conversation

@majing921201
Copy link
Contributor

@majing921201 majing921201 commented Aug 21, 2024

XPU index kernel implementation requires index tensors have the same strides, so we convert their strides in AdvancedIndex API

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 21, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134072

Note: Links to docs will display an error until the docs builds have been completed.

❌ 48 Cancelled Jobs, 10 Unrelated Failures

As of commit 0cebc3f with merge base 255cd75 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@EikanWang EikanWang mentioned this pull request Aug 23, 2024
Closed
@majing921201 majing921201 changed the title Forced XPU index tensors to be contiguous in AdvancedIndex Add XPU backend in check conditions in AdvancedIndex Aug 23, 2024
@majing921201
Copy link
Contributor Author

majing921201 commented Aug 23, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 23, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 23, 2024

Successfully rebased majing/index onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout majing/index && git pull --rebase)

albanD
albanD previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure
Please add test before merging.

@albanD albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 27, 2024
@albanD albanD requested a review from EikanWang August 27, 2024 14:42
EikanWang
EikanWang previously approved these changes Aug 27, 2024
View reviewed changes
@majing921201
Copy link
Contributor Author

majing921201 commented Aug 28, 2024

We have duplicated PR #134453, so close this one.

@EikanWang EikanWang reopened this Aug 28, 2024
@pytorch-bot pytorch-bot bot dismissed stale reviews from albanD and EikanWang August 28, 2024 15:18

This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.

@EikanWang EikanWang closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD left review comments

@EikanWang EikanWang EikanWang left review comments

Assignees

No one assigned

Labels

open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

PyTorch Intel
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@majing921201 @pytorchmergebot @albanD @EikanWang @pytorchbot