test_execution_trace.py: Use instantiate_device_type_tests to run GPU tests on HPU as well #133975

amathewc · 2024-08-20T06:22:24Z

MOTIVATION

We recently integrated support for Intel Gaudi devices (identified as 'hpu') into the common_device_type framework via the pull request at #126970. This integration allows tests to be automatically instantiated for Gaudi devices upon loading the relevant library. Building on this development, the current pull request extends the utility of these hooks by adapting selected CUDA tests to operate on Gaudi devices. Additionally, we have confirmed that these modifications do not interfere with the existing tests on CUDA devices.

CHANGES

Add support for HPU devices within the payload function.
Use instantiate_device_type_tests with targeted attributes to generate device-specific test instances.
Expand the supported_activities() function to include checks for torch.profiler.ProfilerActivity.HPU.
Apply skipIfHPU decorator to bypass tests that are not yet compatible with HPU devices.

pytorch-bot · 2024-08-20T06:22:28Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133975

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c87edef with merge base 28a521e ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

amathewc · 2024-08-27T08:54:55Z

Hi @sraikund16 :
Just wanted to remind you about this PR. Please let me know if you need any additional information or changes from my side.
Thanks!

aaronenyeshi · 2024-08-28T14:30:12Z

Could this diff be stacked on top of this refactor? #134316

amathewc · 2024-08-29T09:18:43Z

Could this diff be stacked on top of this refactor? #134316

@aaronenyeshi : It seems like the PR mentioned (#134316 ) provides support of in-tree devices. Since Intel Gaudi (HPU) is an out-of-tree device, we needed a different approach . Please refer to this #126970 as well.
Adding @jgong5 and @ankurneog for further comments.

ankurneog · 2024-08-30T06:29:07Z

@aaronenyeshi : i agree with @amathewc , we can give the flexibility per file/module. Each device based on the its capability can include itself per module /file (eg :

pytorch/test/dynamo/test_model_output.py

Line 348 in 1011e0a

if TEST_HPU:

)
we should merge both the changes inline so that its useful for out-of-tree devices such as Intel Gaudi.

aaronenyeshi · 2024-09-03T15:14:01Z

Sounds good, cc @sanrise , @briancoutinho , @shengfukevin - please take a look. The changes are related to the execution trace test.

amathewc · 2024-09-18T04:36:27Z

Sounds good, cc @sanrise , @briancoutinho , @shengfukevin - please take a look. The changes are related to the execution trace test.

@aaronenyeshi , @sanrise , @briancoutinho , @shengfukevin : Any update on this ? any further changes needed from our side?

briancoutinho · 2024-09-19T21:19:03Z

Looks great, just some minor suggestions. @amathewc can you rebase on viablestrict branch, that should ensure all the checks will be passing.

test/profiler/test_execution_trace.py

briancoutinho · 2024-09-19T21:15:59Z

test/profiler/test_execution_trace.py

amathewc · 2024-09-20T03:32:46Z

@aaronenyeshi , @sanrise , @briancoutinho , @shengfukevin : Removed the extra lines as per review comments.

amathewc · 2024-09-25T03:46:50Z

@shengfukevin , @sanrise , @sraikund16 : Any further changes required from our side for merging this PR ?

amathewc · 2024-09-25T04:39:50Z

@pytorchbot rebase

pytorch-bot · 2024-09-25T04:39:54Z

You don't have permissions to rebase this PR since you are a first time contributor. If you think this is a mistake, please contact PyTorch Dev Infra.

sraikund16 · 2024-09-25T22:40:28Z

@amathewc Can you rebase/merge using git and push to the branch to start testing

sraikund16 · 2024-09-26T22:57:35Z

@pytorchbot rebase

pytorchmergebot · 2024-09-26T22:59:13Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2024-09-26T22:59:18Z

Successfully rebased profiler_test_updates onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout profiler_test_updates && git pull --rebase)

amathewc · 2024-09-29T02:52:54Z

@aaronenyeshi , @sanrise , @briancoutinho , @shengfukevin, @sraikund16 : could you help in rebase/merge this ? Looks like I do not have the permissions.
The CI failures are in unrelated files.

amathewc · 2024-09-30T04:55:00Z

@pytorchbot merge

jgong5 · 2024-10-12T13:39:58Z

@pytorchbot rebase

pytorchmergebot · 2024-10-12T13:41:30Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2024-10-12T13:41:32Z

Successfully rebased profiler_test_updates onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout profiler_test_updates && git pull --rebase)

amathewc · 2024-10-16T03:34:10Z

@aaronenyeshi , @sanrise , @briancoutinho , @shengfukevin, @sraikund16 , @jgong5 : Could you help in merging this ? I don't seem to be authorized to merge this. Have fixed all lint related issues.

pytorch-bot · 2024-10-16T04:09:39Z

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'merger' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'cherry-pick', 'close')

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

ankurneog · 2024-10-16T04:09:59Z

@pytorchbot merge

pytorchmergebot · 2024-10-16T04:11:34Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-10-16T04:11:37Z

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

ankurneog · 2024-10-16T04:13:25Z

@pytorchbot rebase

pytorchmergebot · 2024-10-16T04:14:57Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

… tests on HPU as well

pytorchmergebot · 2024-10-16T04:15:00Z

Successfully rebased profiler_test_updates onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout profiler_test_updates && git pull --rebase)

ankurneog · 2024-10-16T07:46:02Z

@pytorchbot merge

pytorchmergebot · 2024-10-16T07:47:47Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorch-bot bot added the topic: not user facing topic category label Aug 20, 2024

pytorchbot added the open source label Aug 20, 2024

soulitzer requested review from aaronenyeshi, briancoutinho and shengfukevin August 21, 2024 00:01

soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 21, 2024

aaronenyeshi requested a review from sraikund16 August 21, 2024 17:46

aaronenyeshi requested a review from sanrise September 3, 2024 15:13

briancoutinho approved these changes Sep 19, 2024

View reviewed changes

aaronenyeshi approved these changes Sep 20, 2024

View reviewed changes

pytorchmergebot force-pushed the profiler_test_updates branch from a95c3b3 to ec51d9f Compare September 26, 2024 22:59

amathewc force-pushed the profiler_test_updates branch from de493e1 to bf93602 Compare September 27, 2024 05:11

pytorchmergebot force-pushed the profiler_test_updates branch from bf93602 to d1b61a5 Compare October 12, 2024 13:41

pytorchmergebot added the merging label Oct 16, 2024

pytorchmergebot removed the merging label Oct 16, 2024

amathewc added 5 commits October 16, 2024 04:14

test_execution_trace.py: Use instantiate_device_type_tests to run GPU…

5ac3b79

… tests on HPU as well

Updated code based on review feedback

e1b3b1d

Updated code based on @briancoutinho 's feedback

d508a49

Removed lines as per @briancoutinho 's comments

f0054e1

Minor update as per lint suggestion

c87edef

pytorchmergebot force-pushed the profiler_test_updates branch from 015dc28 to c87edef Compare October 16, 2024 04:15

pytorchmergebot added the merging label Oct 16, 2024

pytorchmergebot added the Merged label Oct 16, 2024

pytorchmergebot closed this in 7f88bf9 Oct 16, 2024

pytorchmergebot removed the merging label Oct 16, 2024

amathewc deleted the profiler_test_updates branch October 16, 2024 08:40

ankurneog mentioned this pull request Mar 5, 2025

[RFC] Generalize pytorch content for non-native device execution pytorch/rfcs#66

Open

test_execution_trace.py: Use instantiate_device_type_tests to run GPU tests on HPU as well #133975

test_execution_trace.py: Use instantiate_device_type_tests to run GPU tests on HPU as well #133975

Uh oh!

Conversation

amathewc commented Aug 20, 2024

Uh oh!

pytorch-bot bot commented Aug 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133975

✅ No Failures

Uh oh!

amathewc commented Aug 27, 2024

Uh oh!

aaronenyeshi commented Aug 28, 2024

Uh oh!

amathewc commented Aug 29, 2024

Uh oh!

ankurneog commented Aug 30, 2024

Uh oh!

aaronenyeshi commented Sep 3, 2024

Uh oh!

amathewc commented Sep 18, 2024

Uh oh!

briancoutinho commented Sep 19, 2024

Uh oh!

Uh oh!

Uh oh!

briancoutinho Sep 19, 2024

Choose a reason for hiding this comment

Uh oh!

amathewc Sep 20, 2024

Choose a reason for hiding this comment

Uh oh!

amathewc commented Sep 20, 2024

Uh oh!

amathewc commented Sep 25, 2024

Uh oh!

amathewc commented Sep 25, 2024

Uh oh!

pytorch-bot bot commented Sep 25, 2024

Uh oh!

sraikund16 commented Sep 25, 2024

Uh oh!

sraikund16 commented Sep 26, 2024

Uh oh!

pytorchmergebot commented Sep 26, 2024

Uh oh!

pytorchmergebot commented Sep 26, 2024

Uh oh!

amathewc commented Sep 29, 2024

Uh oh!

amathewc commented Sep 30, 2024

Uh oh!

jgong5 commented Oct 12, 2024

Uh oh!

pytorchmergebot commented Oct 12, 2024

Uh oh!

pytorchmergebot commented Oct 12, 2024

Uh oh!

amathewc commented Oct 16, 2024

Uh oh!

pytorch-bot bot commented Oct 16, 2024

Uh oh!

ankurneog commented Oct 16, 2024

Uh oh!

pytorchmergebot commented Oct 16, 2024

Merge started

Uh oh!

pytorchmergebot commented Oct 16, 2024

Merge failed

Uh oh!

ankurneog commented Oct 16, 2024

Uh oh!

pytorchmergebot commented Oct 16, 2024

Uh oh!

pytorchmergebot commented Oct 16, 2024

Uh oh!

ankurneog commented Oct 16, 2024

Uh oh!

pytorch-bot bot commented Aug 20, 2024 •

edited

Loading