-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Remove unused Python variables in torch/[_-a]* #133492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133492
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit e9d7afa with merge base 18785c1 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ghstack-source-id: 9956e55 Pull Request resolved: pytorch#133492
ghstack-source-id: 677419f Pull Request resolved: pytorch#133492
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 jobs have failed, first few of them are: trunk / linux-focal-rocm6.2-py3.10 / test (default, 1, 2, linux.rocm.gpu), trunk / linux-focal-rocm6.2-py3.10 / test (distributed, 1, 1, linux.rocm.gpu) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot rebase -b main |
|
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
|
Rebase failed due to |
|
@pytorchbot rebase -b main |
|
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
|
Rebase failed due to |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
A rebase isn't going to work, because the commit is already contained in The solution I used was to go to the desired commit ID - I picked If I did something like this, and it's cooking right now. |
|
Fine , merge it! |
Summary: X-link: pytorch/pytorch#133492 Approved by: https://github.com/albanD Reviewed By: clee2000 Differential Revision: D67153461 fbshipit-source-id: 2182ae5048821fd2670dc42e056ebb833986b869
* Extracted from pytorch/pytorch#133492 ghstack-source-id: 4103a77 Pull Request resolved: pytorch/pytorch#138473
---- * Extracted from #133492 Pull Request resolved: #138473 Approved by: https://github.com/EikanWang, https://github.com/albanD, https://github.com/xuhancn
Stack from ghstack (oldest at bottom):
cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov @LucasLLC @MeetVadakkanchery @mhorowitz @pradeepfn @XilunWu