[Reland] Add wrappers for synchronous GPUDirect Storage APIs #133489
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133489
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7b7abe3 with merge base c2eeda5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
@mikaylagawarecki has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
malfet
pushed a commit
to aditew01/pytorch
that referenced
this pull request
Sep 13, 2024
…#133489) Reland pytorch#130633 USE_CUFILE turned off by default in this version Pull Request resolved: pytorch#133489 Approved by: https://github.com/albanD
kit1980
added a commit
that referenced
this pull request
Oct 18, 2024
cufile is not available in AlmaLinux/AmazonLinux default configuration. cufile is not actually used currently by default - #133489
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 22, 2024
Trying to loading it caused a big issue with 2.5.0 release - #138324 cufile is not actually used currently by default, see #133489 Pull Request resolved: #138501 Approved by: https://github.com/atalman, https://github.com/mikaylagawarecki, https://github.com/malfet
pytorchbot
pushed a commit
that referenced
this pull request
Oct 22, 2024
Trying to loading it caused a big issue with 2.5.0 release - #138324 cufile is not actually used currently by default, see #133489 Pull Request resolved: #138501 Approved by: https://github.com/atalman, https://github.com/mikaylagawarecki, https://github.com/malfet (cherry picked from commit 012ff2a)
kit1980
added a commit
that referenced
this pull request
Oct 22, 2024
Don't try to load cufile (#138501) Trying to loading it caused a big issue with 2.5.0 release - #138324 cufile is not actually used currently by default, see #133489 Pull Request resolved: #138501 Approved by: https://github.com/atalman, https://github.com/mikaylagawarecki, https://github.com/malfet (cherry picked from commit 012ff2a) Co-authored-by: Sergii Dymchenko <[email protected]>
SamGinzburg
pushed a commit
that referenced
this pull request
Oct 28, 2024
Trying to loading it caused a big issue with 2.5.0 release - #138324 cufile is not actually used currently by default, see #133489 Pull Request resolved: #138501 Approved by: https://github.com/atalman, https://github.com/mikaylagawarecki, https://github.com/malfet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland #130633
Based in part on NVIDIA/apex#1774
USE_CUFILE turned off by default in this version