Skip to content

Add dtypes support in opinfo for Intel Gaudi #132840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ankurneog wants to merge 1 commit into from
Closed

Add dtypes support in opinfo for Intel Gaudi #132840

ankurneog wants to merge 1 commit into from

Conversation

@ankurneog
Copy link

@ankurneog ankurneog commented Aug 7, 2024 •
edited by pytorch-bot bot
Loading

Motivation

This is following up on changes introduced in #128584
we are adding the dtype information to be picked up while executing the UTs for Intel Gaudi/HPU

cc @frank-wei @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 7, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132840

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit d7d0682 with merge base 7f98781 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ankurneog ankurneog marked this pull request as ready for review August 7, 2024 09:47
@ankurneog ankurneog requested a review from mruberry as a code owner August 7, 2024 09:47
@ankurneog
Copy link
Author

ankurneog commented Aug 7, 2024

@albanD : can you please help with the review, thanks

@ankurneog ankurneog force-pushed the ankurneog_hpu_opinfo-1 branch from b3d82b5 to 24b9711 Compare August 7, 2024 16:45
@cpuhrsch cpuhrsch requested a review from albanD August 8, 2024 01:10
@cpuhrsch cpuhrsch added module: intel Specific to x86 architecture triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Aug 8, 2024
@ankurneog
Copy link
Author

ankurneog commented Aug 14, 2024

@albanD : can you please help with the review and approval. thanks

1 similar comment
@ankurneog
Copy link
Author

ankurneog commented Aug 28, 2024

@albanD : can you please help with the review and approval. thanks

@ankurneog ankurneog force-pushed the ankurneog_hpu_opinfo-1 branch from 24b9711 to 8ef30f0 Compare August 30, 2024 03:49
@ankurneog
Copy link
Author

ankurneog commented Sep 12, 2024

@albanD : gentle reminder, can you please help with the review and approval. thanks

albanD
albanD approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry long todo list.
Sounds good!

@ankurneog
Copy link
Author

ankurneog commented Sep 17, 2024

@pytorchbot merge

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 17, 2024

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

@ankurneog
Copy link
Author

ankurneog commented Sep 17, 2024

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 17, 2024
@ankurneog
Copy link
Author

ankurneog commented Sep 17, 2024

@pytorchbot merge

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 17, 2024

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

@ankurneog ankurneog force-pushed the ankurneog_hpu_opinfo-1 branch from 8ef30f0 to 5fb5ed2 Compare September 17, 2024 02:41
@ankurneog
Copy link
Author

ankurneog commented Sep 17, 2024

@pytorchbot merge

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 17, 2024

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

@ankurneog
Copy link
Author

ankurneog commented Sep 17, 2024

@pytorchbot merge

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 17, 2024

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

@ankurneog
Copy link
Author

ankurneog commented Sep 17, 2024

@pytorchbot merge

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 17, 2024

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

@ankurneog
Copy link
Author

ankurneog commented Sep 18, 2024

@pytorchbot merge

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 18, 2024

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

@ankurneog
Copy link
Author

ankurneog commented Sep 18, 2024 •
edited
Loading

@albanD / @fegin : Could you kindly help with the merge, is anything missing ? I am not able to merge these changes.

@jgong5
Copy link
Collaborator

jgong5 commented Sep 20, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 20, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 20, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 20, 2024

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@ankurneog
Copy link
Author

ankurneog commented Sep 23, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 23, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 23, 2024

Successfully rebased ankurneog_hpu_opinfo-1 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout ankurneog_hpu_opinfo-1 && git pull --rebase)

@ankurneog ankurneog force-pushed the ankurneog_hpu_opinfo-1 branch from 8366bc7 to d7d0682 Compare September 24, 2024 05:47
@ankurneog
Copy link
Author

ankurneog commented Sep 24, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 24, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 24, 2024

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@albanD
Copy link
Collaborator

albanD commented Sep 24, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 24, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@ankurneog ankurneog deleted the ankurneog_hpu_opinfo-1 branch September 25, 2024 02:40
BoyuanFeng pushed a commit to BoyuanFeng/pytorch that referenced this pull request Sep 25, 2024
@BoyuanFeng
Add dtypes support in opinfo for Intel Gaudi (pytorch#132840)
ec00c20 
## Motivation
This is following up on changes introduced in pytorch#128584
we are adding the dtype information to be picked up while executing the UTs for Intel Gaudi/HPU

Pull Request resolved: pytorch#132840
Approved by: https://github.com/albanD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: intel Specific to x86 architecture open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ankurneog @jgong5 @pytorchmergebot @albanD @cpuhrsch @pytorchbot