Skip to content

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Aug 1, 2024

URL: https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm is not available anymore, hence replacing this with yum epel-release install.

As a backup plan this is available still : https://archives.fedoraproject.org/pub/archive/epel/7/x86_64/Packages/e/epel-release-7-14.noarch.rpm

Saved on our s3 path, just in case: https://ossci-linux.s3.amazonaws.com/epel-release-7-14.noarch.rpm

Please note, We are still using for installs like this:

RUN yum install -y \
    https://repo.ius.io/ius-release-el7.rpm \
	https://ossci-linux.s3.amazonaws.com/epel-release-7-14.noarch.rpm

Test in CI

@atalman atalman requested a review from jeffdaily as a code owner August 1, 2024 21:53
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 1, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132449

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Cancelled Jobs, 8 Unrelated Failures

As of commit 6721e08 with merge base 92bebb4 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 1, 2024
fix

fix

test

test

test

Revert "test"

This reverts commit c265587.
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though we should move away from CentOS 7

@atalman
Copy link
Contributor Author

atalman commented Aug 2, 2024

@pytorchmergebot merge -f "lint and docker builds are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

jithunnair-amd added a commit to ROCm/builder that referenced this pull request Aug 6, 2024
* Update ROCm instructions for manylinux

* Sync devtoolset version to 11 with CUDA manylinux_2_28 entry

* Update Dockerfile for ROCm

* Add almalinux case

* Use | to OR different conditions and avoid repetition

* Use devtoolset 11 in alignment with CUDA manylinux config

* Magma build preinstalls

(cherry picked from commit 9a803c9)

* Add symlink to python

(cherry picked from commit 5c4bf9f)

* Add ROCM_PATH

* Use cpu_final to get the devtoolset PATH/LD_LIBRARY_PATH settings and pip cmake install

* Move creation of python link to install_rocm_magma.sh since it's only needed for Magma

* Cmake updates

* Add Almalinux case for bundling system libs

* Set _GLIBCXX_USE_CXX11_ABI=1 for ROCm since RHEL8 ROCm packages refer to cxx11-abi symbols, so PyTorch build fails if _GLIBCXX_USE_CXX11_ABI=0

* Need * to have a match

* Install numpy<2.0.0 for older release branches

* Enable MIOpen build from source for ROCm6.1 to see if it resolves segfault issue
Remove existing sqlite3.pc to make cget happy

* Add conditions for ROCm6.2 and ROCm6.3

* Don't use set -e

* Upgrade cmake version to enable CK to build for ROCm6.2

* Disable building from source for MIOpen and reinstate set -e

* Add librocm-core.so (#50)

(cherry picked from commit 2d3fb6f)

* Remove all references to devtoolset

* Update cmake version to 3.28.4

* Skip epel-7 rpm download

* Skip epel-7 rpm download

* Install epel-7 from PyTorch AWS backup repo (similar to upstream PR pytorch/pytorch#132449

* Use DEVTOOLSET_VERSION 9 for manylinux2_28

* Move AOTriton build step to PyTorch build script (since different aotriton for different pytorch releases)

* Install libaotriton_v2.so before we look for it

* Comments

* Comments

* Revert "Remove all references to devtoolset"

This reverts commit 43d70a7.

* Comments

* Add gfx942 as default arch

* Use correct GPU_IMAGE for manylinux_2_28

* Tab lint

* Do not rebuild CK; Remove old ROCm cruft

---------

Co-authored-by: Pruthvi Madugundu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants