Remove python 3.8 nightly builds #132138
Closed
Remove python 3.8 nightly builds #132138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132138
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
albanD
approved these changes
Jul 30, 2024
Collaborator
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
Do we want ciflow/binaries to make sure nothing weird still depend on these?
Otherwise sounds good
albanD
added
topic: bc breaking
malfet
approved these changes
Jul 30, 2024
ZainRizvi
added
the
ciflow/binaries
huydhn
approved these changes
Jul 30, 2024
Contributor
huydhn
left a comment
huydhn
left a comment
There was a problem hiding this comment.
LGTM! As ExecuTorch build doesn't work with 3.8, we can ping ExecuTorch folks about this and pytorch/test-infra#5517 so that they don't need to figure out a way to support that version anymore (cc @guangy10 @dbort)
Contributor
Thanks for pointing this out. I was actually looking at implementing matrix without 3.8 for ET. |
Contributor
Author
|
@pytorchmergebot merge -f "lint sanity check is expected" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
malfet
added a commit
that referenced
this pull request
Sep 30, 2024
Closed
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 30, 2024
By migrating some of the workflows to Python-3.9 as 3.8 has been deprecated by #132138 Pull Request resolved: #137023 Approved by: https://github.com/ZainRizvi, https://github.com/janeyx99, https://github.com/seemethere, https://github.com/kit1980, https://github.com/Skylion007
pytorchbot
pushed a commit
that referenced
this pull request
Sep 30, 2024
By migrating some of the workflows to Python-3.9 as 3.8 has been deprecated by #132138 Pull Request resolved: #137023 Approved by: https://github.com/ZainRizvi, https://github.com/janeyx99, https://github.com/seemethere, https://github.com/kit1980, https://github.com/Skylion007 (cherry picked from commit 40f80a7)
Merged
malfet
added a commit
that referenced
this pull request
Sep 30, 2024
Fix lint (#137023) By migrating some of the workflows to Python-3.9 as 3.8 has been deprecated by #132138 Pull Request resolved: #137023 Approved by: https://github.com/ZainRizvi, https://github.com/janeyx99, https://github.com/seemethere, https://github.com/kit1980, https://github.com/Skylion007 (cherry picked from commit 40f80a7) Co-authored-by: Nikita Shulga <[email protected]>
AnantGulati
pushed a commit
to AnantGulati/pytorch
that referenced
this pull request
Oct 2, 2024
By migrating some of the workflows to Python-3.9 as 3.8 has been deprecated by pytorch#132138 Pull Request resolved: pytorch#137023 Approved by: https://github.com/ZainRizvi, https://github.com/janeyx99, https://github.com/seemethere, https://github.com/kit1980, https://github.com/Skylion007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing python 3.8 support in nightly builds. As per PR: #120718