[export] Support "custom" metadata field. #131912

zhxchen17 · 2024-07-26T17:16:27Z

Summary:
Add a special field in Graph and Node level metadata called "custom" which should be mapped to a json-serializable object, and we guarantee this field should be always preversed across the following transformations:

copy/deepcopy
run_decompositions()
serialization
re-exporting

Test Plan: :test_export -- -r custom_tag

Reviewed By: angelayi

Differential Revision: D60291839

pytorch-bot · 2024-07-26T17:16:30Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/131912

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 874879d with merge base 2fde193 ():

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

Lint / lintrunner-noclang / linux-job (gh) (trunk failure)
>>> Lint for torch/_inductor/runtime/triton_heuristics.py:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-07-26T17:16:45Z

This pull request was exported from Phabricator. Differential Revision: D60291839

SherlockNoMad · 2024-07-26T20:02:47Z

This special field behavior should be documented somewhere...

SherlockNoMad

lgtm with comment.

Do you plan to add the register_custom_field() API for nn.Module next?

test/export/test_serialize.py

torch/_export/serde/serialize.py

zhxchen17 · 2024-07-29T16:16:33Z

Do you plan to add the register_custom_field() API for nn.Module next?

@SherlockNoMad no I don't plan to work on it in the near future.

facebook-github-bot · 2024-07-29T17:19:14Z

This pull request was exported from Phabricator. Differential Revision: D60291839

facebook-github-bot · 2024-07-29T17:25:39Z

This pull request was exported from Phabricator. Differential Revision: D60291839

facebook-github-bot · 2024-07-29T18:19:28Z

This pull request was exported from Phabricator. Differential Revision: D60291839

Summary: Pull Request resolved: pytorch#131912 Add a special field in Graph and Node level metadata called "custom" which should be mapped to a json-serializable object, and we guarantee this field should be always preversed across the following transformations: 1. copy/deepcopy 2. run_decompositions() 3. serialization 4. re-exporting Test Plan: :test_export -- -r custom_tag Reviewed By: angelayi Differential Revision: D60291839

facebook-github-bot · 2024-07-30T15:35:56Z

This pull request was exported from Phabricator. Differential Revision: D60291839

facebook-github-bot · 2024-07-30T15:40:46Z

This pull request was exported from Phabricator. Differential Revision: D60291839

Summary: Pull Request resolved: pytorch#131912 Add a special field in Graph and Node level metadata called "custom" which should be mapped to a json-serializable object, and we guarantee this field should be always preversed across the following transformations: 1. copy/deepcopy 2. run_decompositions() 3. serialization 4. re-exporting Test Plan: :test_export -- -r custom_tag Reviewed By: angelayi Differential Revision: D60291839

facebook-github-bot · 2024-07-30T17:33:17Z

This pull request was exported from Phabricator. Differential Revision: D60291839

Summary: Pull Request resolved: pytorch#131912 Add a special field in Graph and Node level metadata called "custom" which should be mapped to a json-serializable object, and we guarantee this field should be always preversed across the following transformations: 1. copy/deepcopy 2. run_decompositions() 3. serialization 4. re-exporting Test Plan: :test_export -- -r custom_tag Reviewed By: angelayi Differential Revision: D60291839

facebook-github-bot · 2024-08-13T18:48:54Z

This pull request was exported from Phabricator. Differential Revision: D60291839

facebook-github-bot · 2024-08-14T01:07:15Z

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

pytorchmergebot · 2024-08-14T01:08:52Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

lint

lint Fixes #ISSUE_NUMBER Pull Request resolved: #133428 Approved by: https://github.com/aaronenyeshi

Summary: With #131912 we now have a "custom" field in node.meta that can be preserved in * copy/deepcopy * run_decompositions() * serialization * re-exporting So we refactored numeric debugger to use this. Test Plan: python test/test_quantization.py TestNumericDebugger Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

…eld" Summary: With #131912 we now have a "custom" field in node.meta that can be preserved in * copy/deepcopy * run_decompositions() * serialization * re-exporting So we refactored numeric debugger to use this. Test Plan: python test/test_quantization.py TestNumericDebugger Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

Summary: With #131912 we now have a "custom" field in node.meta that can be preserved in * copy/deepcopy * run_decompositions() * serialization * re-exporting So we refactored numeric debugger to use this. Test Plan: python test/test_quantization.py TestNumericDebugger Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: b6af5d0 Pull Request resolved: #134040

Summary: With #131912 we now have a "custom" field in node.meta that can be preserved in * copy/deepcopy * run_decompositions() * serialization * re-exporting So we refactored numeric debugger to use this. Test Plan: python test/test_quantization.py TestNumericDebugger Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: #134040 Approved by: https://github.com/tarun292

…h#134040) Summary: With pytorch#131912 we now have a "custom" field in node.meta that can be preserved in * copy/deepcopy * run_decompositions() * serialization * re-exporting So we refactored numeric debugger to use this. Test Plan: python test/test_quantization.py TestNumericDebugger Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: pytorch#134040 Approved by: https://github.com/tarun292

Summary: Improves and enables a commented out test originally introduced in #131912 In `test_custom_tag_metadata_re_export()`, we check the added "custom" metadata to given nodes is preserved and not copied to other nodes after re-exporting Reviewed By: zhxchen17 Differential Revision: D62880574 Pulled By: yiming0416

Improves and enables a commented out test originally introduced in #131912 In `test_custom_tag_metadata_re_export()`, we check the added "custom" metadata to given nodes is preserved and not copied to other nodes after re-exporting Pull Request resolved: #136048 Approved by: https://github.com/zhxchen17

Improves and enables a commented out test originally introduced in pytorch#131912 In `test_custom_tag_metadata_re_export()`, we check the added "custom" metadata to given nodes is preserved and not copied to other nodes after re-exporting Pull Request resolved: pytorch#136048 Approved by: https://github.com/zhxchen17

lint Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#133428 Approved by: https://github.com/aaronenyeshi

zhxchen17 requested review from angelayi, avikchaudhuri, tugsbayasgalan and ydwu4 as code owners July 26, 2024 17:16

pytorch-bot bot added ciflow/inductor release notes: fx release notes category labels Jul 26, 2024

facebook-github-bot added the fb-exported label Jul 26, 2024

SherlockNoMad reviewed Jul 26, 2024

View reviewed changes

test/export/test_serialize.py Outdated Show resolved Hide resolved

torch/_export/serde/serialize.py Show resolved Hide resolved

torch/_export/serde/serialize.py Outdated Show resolved Hide resolved

zhxchen17 force-pushed the export-D60291839 branch from 597243e to dd91cbf Compare July 29, 2024 17:19

zhxchen17 force-pushed the export-D60291839 branch from dd91cbf to 552d2e1 Compare July 29, 2024 17:25

zhxchen17 force-pushed the export-D60291839 branch from 552d2e1 to f646e4b Compare July 29, 2024 18:19

zhxchen17 requested a review from SherlockNoMad July 29, 2024 18:23

zhxchen17 force-pushed the export-D60291839 branch from f646e4b to e6a04d2 Compare July 30, 2024 15:35

zhxchen17 force-pushed the export-D60291839 branch from e6a04d2 to 4e5755f Compare July 30, 2024 15:40

pytorchmergebot added the merging label Aug 14, 2024

pytorchmergebot added the Merged label Aug 14, 2024

pytorchmergebot closed this in f23dbef Aug 14, 2024

pytorchmergebot removed the merging label Aug 14, 2024

nmacchioni added a commit that referenced this pull request Aug 14, 2024

[lint] fix lint broken by #131912

bd61fd3

lint

nmacchioni mentioned this pull request Aug 14, 2024

[lint] fix lint broken by #131912 #133428

Closed

jerryzh168 mentioned this pull request Aug 20, 2024

Update pt2e numeric debugger to use node.meta["custom"] field #134040

Closed

yiming0416 mentioned this pull request Sep 13, 2024

[export] enable custom tag metadata re-export test #136048

Closed

[export] Support "custom" metadata field. #131912

[export] Support "custom" metadata field. #131912

Uh oh!

Conversation

zhxchen17 commented Jul 26, 2024

Uh oh!

pytorch-bot bot commented Jul 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/131912

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

facebook-github-bot commented Jul 26, 2024

Uh oh!

SherlockNoMad commented Jul 26, 2024

Uh oh!

SherlockNoMad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zhxchen17 commented Jul 29, 2024

Uh oh!

facebook-github-bot commented Jul 29, 2024

Uh oh!

facebook-github-bot commented Jul 29, 2024

Uh oh!

facebook-github-bot commented Jul 29, 2024

Uh oh!

facebook-github-bot commented Jul 30, 2024

Uh oh!

facebook-github-bot commented Jul 30, 2024

Uh oh!

facebook-github-bot commented Jul 30, 2024

Uh oh!

facebook-github-bot commented Aug 13, 2024

Uh oh!

facebook-github-bot commented Aug 14, 2024

Uh oh!

pytorchmergebot commented Aug 14, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pytorch-bot bot commented Jul 26, 2024 •

edited

Loading