[BE] typing for decorators - distributed/_composable/contract #131590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #131429 [ghstack-poisoned]
This was referenced Jul 24, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/131590
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit 27bb8e2 with merge base baa93e1 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
oncall: distributed
This was referenced Jul 24, 2024
Closed
oulgen
approved these changes
Jul 24, 2024
…act" See #131429 [ghstack-poisoned]
zou3519
approved these changes
Jul 24, 2024
…act" See #131429 [ghstack-poisoned]
…act" See #131429 [ghstack-poisoned]
…act" See #131429 [ghstack-poisoned]
…act" See #131429 [ghstack-poisoned]
…act" See #131429 [ghstack-poisoned]
…act" See #131429 [ghstack-poisoned]
awgu
reviewed
Jul 25, 2024
| @wraps(state_cls) | ||
| def inner(func): | ||
| @wraps(func) | ||
| # @wraps(state_cls) |
Collaborator
There was a problem hiding this comment.
nit: Is this meant to be left in?
| ) -> _ContractFn[ | ||
| Concatenate[Union[nn.Module, Sequence[nn.Module]], _P], _T, _TState | ||
| ]: | ||
| # @wraps(func) |
…act" See #131429 cc XilunWu H-Huang awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
See #131429
cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o