[BE] typing for decorators - optim/optimizer #131583
Conversation
See #131429 [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/131583
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (5 Unrelated Failures)As of commit c1f6928 with merge base 1eedb0a ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| ) | ||
| from torch.utils.hooks import RemovableHandle | ||
|
|
||
| _T = TypeVar("_T") |
There was a problem hiding this comment.
There's a T for TypeVar("T") below -- what does the underscore mean here?
There was a problem hiding this comment.
Underscore means the name is private to the file. I could have used the 'T' version as well - but I didn't want to make any implied guarantees about the type name having any external meaning.
janeyx99
left a comment
janeyx99
left a comment
There was a problem hiding this comment.
Looks fine, thanks!
Left a q about the underscore
See #131429 [ghstack-poisoned]
See #131429 ghstack-source-id: 4029c13 Pull Request resolved: pytorch/pytorch#131583
|
@pytorchbot merge -f "passed tests on #131589 but one PR in the middle of the stack is missing review" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchmergebot revert -c nosignal -m "Breaks CI: GH job link HUD commit link" |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@aorenste your PR has been successfully reverted. |
This reverts commit a1dad77. Reverted #131583 on behalf of https://github.com/atalman due to Breaks CI: [GH job link](https://github.com/pytorch/pytorch/actions/runs/10105959146/job/27947741162) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/a1dad77dfa4e244a867ca7c73e9f6b6fe36a1340) ([comment](#131583 (comment)))
Stack from ghstack (oldest at bottom):
See #131429