[BE] typing for decorators - fx/_compatibility #131568
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #131429 [ghstack-poisoned]
aorenste
requested review from
angelayi,
avikchaudhuri,
justinchuby,
shubhambhokare1,
titaiwangms,
tugsbayasgalan,
wschin,
ydwu4 and
zhxchen17
as code owners
pytorch-bot
bot
added
ciflow/inductor
module: dynamo
module: inductor
oncall: distributed
This was referenced Jul 24, 2024
Closed
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 25, 2024
…nstraint_generator (#131576) See #131429 Pull Request resolved: #131576 Approved by: https://github.com/oulgen, https://github.com/zou3519 ghstack dependencies: #131568, #131569, #131570, #131571, #131572, #131573, #131574, #131575
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 25, 2024
…zer_utils (#131577) See #131429 Pull Request resolved: #131577 Approved by: https://github.com/oulgen, https://github.com/zou3519 ghstack dependencies: #131568, #131569, #131570, #131571, #131572, #131573, #131574, #131575, #131576
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 25, 2024
See #131429 Pull Request resolved: #131578 Approved by: https://github.com/oulgen, https://github.com/zou3519 ghstack dependencies: #131568, #131569, #131570, #131571, #131572, #131573, #131574, #131575, #131576, #131577
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 25, 2024
#131579) See #131429 Pull Request resolved: #131579 Approved by: https://github.com/oulgen, https://github.com/zou3519 ghstack dependencies: #131568, #131569, #131570, #131571, #131572, #131573, #131574, #131575, #131576, #131577, #131578
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 26, 2024
See #131429 Pull Request resolved: #131580 Approved by: https://github.com/oulgen, https://github.com/zou3519 ghstack dependencies: #131568, #131569, #131570, #131571, #131572, #131573, #131574, #131575, #131576, #131577, #131578, #131579
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 26, 2024
See #131429 Pull Request resolved: #131581 Approved by: https://github.com/oulgen, https://github.com/zou3519 ghstack dependencies: #131568, #131569, #131570, #131571, #131572, #131573, #131574, #131575, #131576, #131577, #131578, #131579, #131580
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 26, 2024
See #131429 Pull Request resolved: #131582 Approved by: https://github.com/oulgen, https://github.com/zou3519 ghstack dependencies: #131568, #131569, #131570, #131571, #131572, #131573, #131574, #131575, #131576, #131577, #131578, #131579, #131580, #131581
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 26, 2024
See #131429 Pull Request resolved: #131583 Approved by: https://github.com/janeyx99 ghstack dependencies: #131568, #131569, #131570, #131571, #131572, #131573, #131574, #131575, #131576, #131577, #131578, #131579, #131580, #131581, #131582
Contributor
|
@pytorchbot revert -m "same as #131572 (comment) but I clicked the wrong link by accident. This is where it actually starts" -c ghfirst |
Collaborator
|
@pytorchbot successfully started a revert job. Check the current status here. |
pytorchmergebot
added a commit
that referenced
this pull request
Jul 28, 2024
…131571)" This reverts commit 4b985e6. Reverted #131571 on behalf of https://github.com/clee2000 due to same as #131572 (comment) but I clicked the wrong link by accident. This is where it actually starts ([comment](#131568 (comment)))
pytorchmergebot
added a commit
that referenced
this pull request
Jul 28, 2024
This reverts commit 5731b48. Reverted #131570 on behalf of https://github.com/clee2000 due to same as #131572 (comment) but I clicked the wrong link by accident. This is where it actually starts ([comment](#131568 (comment)))
pytorchmergebot
added a commit
that referenced
this pull request
Jul 28, 2024
This reverts commit aa58af8. Reverted #131569 on behalf of https://github.com/clee2000 due to same as #131572 (comment) but I clicked the wrong link by accident. This is where it actually starts ([comment](#131568 (comment)))
pytorchmergebot
added a commit
that referenced
this pull request
Jul 28, 2024
This reverts commit 193f62f. Reverted #131568 on behalf of https://github.com/clee2000 due to same as #131572 (comment) but I clicked the wrong link by accident. This is where it actually starts ([comment](#131568 (comment)))
Collaborator
|
@aorenste your PR has been successfully reverted. |
bigfootjon
pushed a commit
that referenced
this pull request
Jul 31, 2024
See #131429 Pull Request resolved: #131568 Approved by: https://github.com/justinchuby, https://github.com/oulgen, https://github.com/zou3519 (cherry picked from commit 193f62f)
bigfootjon
pushed a commit
that referenced
this pull request
Jul 31, 2024
See #131429 Pull Request resolved: #131570 Approved by: https://github.com/oulgen, https://github.com/zou3519 ghstack dependencies: #131568, #131569 (cherry picked from commit 5731b48)
bigfootjon
pushed a commit
that referenced
this pull request
Jul 31, 2024
See #131429 Pull Request resolved: #131571 Approved by: https://github.com/oulgen, https://github.com/zou3519 ghstack dependencies: #131568, #131569, #131570 (cherry picked from commit 4b985e6)
bigfootjon
pushed a commit
that referenced
this pull request
Jul 31, 2024
See #131429 Pull Request resolved: #131573 Approved by: https://github.com/oulgen, https://github.com/zou3519 ghstack dependencies: #131568, #131569, #131570, #131571, #131572 (cherry picked from commit f0f20f7)
bigfootjon
pushed a commit
that referenced
this pull request
Jul 31, 2024
…131571)" This reverts commit 4b985e6. Reverted #131571 on behalf of https://github.com/clee2000 due to same as #131572 (comment) but I clicked the wrong link by accident. This is where it actually starts ([comment](#131568 (comment))) (cherry picked from commit a0abb77)
bigfootjon
pushed a commit
that referenced
this pull request
Jul 31, 2024
This reverts commit 5731b48. Reverted #131570 on behalf of https://github.com/clee2000 due to same as #131572 (comment) but I clicked the wrong link by accident. This is where it actually starts ([comment](#131568 (comment))) (cherry picked from commit a3ba405)
bigfootjon
pushed a commit
that referenced
this pull request
Jul 31, 2024
This reverts commit 193f62f. Reverted #131568 on behalf of https://github.com/clee2000 due to same as #131572 (comment) but I clicked the wrong link by accident. This is where it actually starts ([comment](#131568 (comment))) (cherry picked from commit 945bf78)
See #131429 cc XilunWu H-Huang awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
See #131429
cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang