Skip to content

[BE] Remove some mypy allow-untyped-decorators that are no longer needed #131564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aorenste wants to merge 1 commit into from
Closed

[BE] Remove some mypy allow-untyped-decorators that are no longer needed #131564

aorenste wants to merge 1 commit into from

Conversation

@aorenste
Copy link
Contributor

@aorenste aorenste commented Jul 24, 2024 •
edited by pytorch-bot bot
Loading

Stack from ghstack (oldest at bottom):

See #131429

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 24, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/131564

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Cancelled Jobs

As of commit afe8475 with merge base 980bb54 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jul 24, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@aorenste aorenste mentioned this pull request Jul 24, 2024
Closed
@aorenste aorenste requested review from oulgen and zou3519 July 24, 2024 01:01
@aorenste aorenste mentioned this pull request Jul 24, 2024
Open
@aorenste
Copy link
Contributor Author

aorenste commented Jul 24, 2024

@pytorchbot merge -f "mypy-only change passed lintrunner test"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 24, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn huydhn mentioned this pull request Jul 24, 2024
Closed
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
@aorenste @xuhancn
[BE] Remove some mypy allow-untyped-decorators that are no longer nee…
01b5c30 
…ded (pytorch#131564)

See pytorch#131429
Pull Request resolved: pytorch#131564
Approved by: https://github.com/oulgen
@henrylhtsang henrylhtsang mentioned this pull request Jul 31, 2024
Closed
@github-actions github-actions bot deleted the gh/aorenste/88/head branch August 24, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oulgen oulgen oulgen approved these changes

@zou3519 zou3519 Awaiting requested review from zou3519

Assignees

No one assigned

Labels

ciflow/inductor Merged module: dynamo module: inductor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aorenste @pytorchmergebot @oulgen