Only depend on sympy 1.12 for conda (no 3.13 there anyways) #131355

albanD · 2024-07-22T18:28:40Z

Fixing nightly after #130895

pytorch-bot · 2024-07-22T18:28:43Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/131355

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 6271a22 with merge base 56bb047 ():

NEW FAILURES - The following jobs have failed:

windows-binary-conda / conda-py3_9-cuda12_1-build (gh)
An unexpected error has occurred. Conda has prepared the above report.
windows-binary-wheel / wheel-py3_10-cpu-test (gh)
Process completed with exit code 1.

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

Lint / lintrunner-noclang / linux-job (gh) (trunk failure)
>>> Lint for tools/testing/target_determination/heuristics/public_bindings.py:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

XuehaiPan · 2024-07-22T19:40:40Z

.circleci/scripts/binary_linux_test.sh


-if [[ "\$python_nodot" = *38* ]]; then
-  # sympy 1.12.1 is the last version that supports Python 3.8
-  SYMPY_PIN="==1.12.1"


You could search and replace the occurance of 1.2.1 and 1.3.0.

I only want to change the conda ones though, I do want pypi to be on these newer versions

albanD · 2024-07-22T19:41:59Z

Also @XuehaiPan the optree failures are also related to the upgrade you did. Is there no binary release of optree for 3.13 atm?

XuehaiPan · 2024-07-22T19:49:34Z

Also @XuehaiPan the optree failures are also related to the upgrade you did. Is there no binary release of optree for 3.13 atm?

FYI, there is no conda package for optree on anaconda main channel. The latest optree for Python 3.13 support is installable from sdist. The binary wheel of optree for Python 3.13 is not available yet because Python 3.13 is currently not GA.

albanD · 2024-07-22T19:54:35Z

requirements.txt

 setuptools ; python_version >= "3.12"
 packaging
-optree>=0.12.0
+optree>=0.12.0 ; python_version <= "3.12"


FYI @XuehaiPan reverting this as well then as we cannot install it for 3.13 binaries testing as it is only available as an sdist

atalman

lgtm

albanD · 2024-07-22T21:49:40Z

@pytorchbot merge -i

pytorchmergebot · 2024-07-22T21:52:16Z

Merge started

Your change will be merged while ignoring the following 3 checks: Lint / lintrunner-noclang / linux-job, windows-binary-conda / conda-py3_8-cuda12_4-build, windows-binary-wheel / wheel-py3_10-cpu-test

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-07-23T03:50:57Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

XuehaiPan · 2024-07-23T07:49:04Z

@pytorchbot merge

pytorchmergebot · 2024-07-23T07:50:56Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-07-23T07:51:11Z

Merge failed

Reason: 2 jobs have failed, first few of them are: windows-binary-conda / conda-py3_8-cuda12_4-build, windows-binary-wheel / wheel-py3_10-cpu-test

Details for Dev Infra team

Raised by workflow job

XuehaiPan · 2024-07-23T07:54:34Z

@pytorchbot merge -i

pytorchmergebot · 2024-07-23T07:56:25Z

Merge started

Your change will be merged while ignoring the following 3 checks: Lint / lintrunner-noclang / linux-job, windows-binary-conda / conda-py3_8-cuda12_4-build, windows-binary-wheel / wheel-py3_10-cpu-test

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-07-23T08:28:15Z

Merge failed

Reason: 5 jobs have failed, first few of them are: windows-binary-conda / conda-py3_12-cuda12_1-test, windows-binary-conda / conda-py3_8-cuda12_1-test, windows-binary-conda / conda-py3_11-cuda12_4-test, windows-binary-conda / conda-py3_9-cuda12_4-test, windows-binary-conda / conda-py3_12-cuda11_8-test

Details for Dev Infra team

Raised by workflow job

XuehaiPan · 2024-07-23T12:12:24Z

@pytorchbot merge -i

pytorchmergebot · 2024-07-23T12:14:20Z

Merge started

Your change will be merged while ignoring the following 3 checks: Lint / lintrunner-noclang / linux-job, windows-binary-conda / conda-py3_9-cuda12_1-build, windows-binary-wheel / wheel-py3_10-cpu-test

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…131355) Fixing nightly after pytorch#130895 Pull Request resolved: pytorch#131355 Approved by: https://github.com/atalman

Only depend on sympy 1.12 for conda (no 3.13 there anyways)

205657f

albanD requested review from XuehaiPan and atalman July 22, 2024 18:28

pytorch-bot bot added the topic: not user facing topic category label Jul 22, 2024

albanD added ciflow/binaries Trigger all binary build and upload jobs on the PR and removed topic: not user facing topic category labels Jul 22, 2024

XuehaiPan reviewed Jul 22, 2024

View reviewed changes

Revert optree requirement

6271a22

pytorch-bot bot added the topic: not user facing topic category label Jul 22, 2024

albanD commented Jul 22, 2024

View reviewed changes

atalman approved these changes Jul 22, 2024

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 22, 2024

albanD marked this pull request as ready for review July 22, 2024 21:51

pytorchmergebot added the merging label Jul 22, 2024

pytorchmergebot removed the merging label Jul 23, 2024

pytorchmergebot added the merging label Jul 23, 2024

pytorchmergebot removed the merging label Jul 23, 2024

pytorchmergebot added the merging label Jul 23, 2024

pytorchmergebot closed this in eb146b1 Jul 23, 2024

pytorchmergebot added Merged and removed merging labels Jul 23, 2024

XuehaiPan mentioned this pull request Jul 23, 2024

[reland, 2.4] Pin sympy >= 1.13.0 for pip and sympy >= 1.12.0 for conda #131281

Closed

PaliC mentioned this pull request Jul 23, 2024

[BE] Improve error message when there are internal changes #131547

Closed

henrylhtsang mentioned this pull request Jul 31, 2024

[BE][typing] fix types in common pruning #132309

Closed

Only depend on sympy 1.12 for conda (no 3.13 there anyways) #131355

Only depend on sympy 1.12 for conda (no 3.13 there anyways) #131355

Uh oh!

Conversation

albanD commented Jul 22, 2024

Uh oh!

pytorch-bot bot commented Jul 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/131355

❌ 2 New Failures, 1 Unrelated Failure

Uh oh!

XuehaiPan Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

albanD Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

albanD commented Jul 22, 2024

Uh oh!

XuehaiPan commented Jul 22, 2024

Uh oh!

albanD Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

atalman left a comment

Choose a reason for hiding this comment

Uh oh!

albanD commented Jul 22, 2024

Uh oh!

pytorchmergebot commented Jul 22, 2024

Merge started

Uh oh!

pytorchmergebot commented Jul 23, 2024

Uh oh!

XuehaiPan commented Jul 23, 2024

Uh oh!

pytorchmergebot commented Jul 23, 2024

Merge started

Uh oh!

pytorchmergebot commented Jul 23, 2024

Merge failed

Uh oh!

XuehaiPan commented Jul 23, 2024

Uh oh!

pytorchmergebot commented Jul 23, 2024

Merge started

Uh oh!

pytorchmergebot commented Jul 23, 2024

Merge failed

Uh oh!

XuehaiPan commented Jul 23, 2024

Uh oh!

pytorchmergebot commented Jul 23, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pytorch-bot bot commented Jul 22, 2024 •

edited

Loading