Generalize devices specific UTs for dynamo #130714
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130714
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 373945f with merge base 2ee201a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@albanD : Could you please help with this review. Thanks |
colesbury
added
the
triaged
|
@anijain2305 who's the right person on the Dynamo side to review this kind of PRs? |
|
@pytorchbot label "topic: not user facing" |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
pytorchmergebot
force-pushed
the
ankurneog_hpu_dynamo_ut_updates
branch
from
198daf5 to
fb8b02f
Compare
|
@anijain2305 : can you please help with the review , thanks. |
|
@pytorchbot merge |
|
Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra. |
|
@pytorchbot merge |
|
Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
## Motivation This is follow up to PR:pytorch#126970, adding facility to run content for Intel Gaudi devices. We intend to extend similar generalization for the rest of the content in test/dynamo which is currently being written to work specifically for cuda devices. Other devices can add onto it if support is available. ## Changes carve out bert related content to another class use instantiate_device_type utility to instantiate this class for devices which support the functionality Pull Request resolved: pytorch#130714 Approved by: https://github.com/anijain2305
This is in line with changes introduced with #130714, additional files are included to support non-cuda devices. Pull Request resolved: #140929 Approved by: https://github.com/kwen2501, https://github.com/EikanWang, https://github.com/guangyey
6 participants
Motivation
This is follow up to PR:#126970, adding facility to run content for Intel Gaudi devices.
We intend to extend similar generalization for the rest of the content in test/dynamo which is currently being written to work specifically for cuda devices. Other devices can add onto it if support is available.
Changes
carve out bert related content to another class
use instantiate_device_type utility to instantiate this class for devices which support the functionality
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @rec