Avoid autocast deprecation warning in DataParallel #130660

awaelchli · 2024-07-13T01:09:19Z

Fixes #130659

cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o

pytorch-bot · 2024-07-13T01:09:22Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130660

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 1 Unrelated Failure

As of commit 3e1db67 with merge base c1e7e40 ():

NEW FAILURE - The following job has failed:

periodic / win-vs2019-cuda11.8-py3 / test (default, 3, 4, windows.g5.4xlarge.nvidia.gpu) (gh)
test_transformers.py::TestSDPACudaOnlyCUDA::test_mem_efficient_attention_vs_math_ref_grads_batch_size_8_seq_len_q_128_seq_len_k_256_head_dim_128_is_causal_False_dropout_p_0_0_float32_scale_l1_cuda_float32

CANCELLED JOB - The following job was cancelled. Please retry:

pull / linux-focal-py3.8-clang10-onnx / test (default, 2, 2, linux.2xlarge) (gh)
##[error]The operation was canceled.

FLAKY - The following job failed but was likely due to flakiness present on trunk:

periodic / linux-focal-cuda11.8-py3.10-gcc9-debug / test (default, 1, 5, linux.4xlarge.nvidia.gpu) (gh) (similar failure)
'Test'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

torch/nn/parallel/parallel_apply.py

Co-authored-by: Yu, Guangye <[email protected]>

torch/nn/parallel/parallel_apply.py

awaelchli · 2024-07-17T07:39:23Z

Some test workflows failed, but look unrelated. How should I proceed?

guangyey · 2024-07-17T08:20:47Z

Unrelated failures.
@pytorchbot merge -i

pytorchmergebot · 2024-07-17T08:22:36Z

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team

Raised by workflow job

guangyey · 2024-07-17T08:25:06Z

Unrelated failures.
@pytorchbot merge -i

pytorchmergebot · 2024-07-17T08:26:42Z

Merge started

Your change will be merged while ignoring the following 3 checks: pull / linux-focal-py3.8-clang10-onnx / test (default, 2, 2, linux.2xlarge), periodic / win-vs2019-cuda11.8-py3 / test (default, 3, 4, windows.g5.4xlarge.nvidia.gpu), periodic / linux-focal-cuda11.8-py3.10-gcc9-debug / test (default, 1, 5, linux.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Fixes #130659 Co-authored-by: Yu, Guangye <[email protected]> Pull Request resolved: #130660 Approved by: https://github.com/guangyey, https://github.com/fegin, https://github.com/albanD

Fixes pytorch#130659 Co-authored-by: Yu, Guangye <[email protected]> Pull Request resolved: pytorch#130660 Approved by: https://github.com/guangyey, https://github.com/fegin, https://github.com/albanD

atalman · 2024-08-15T17:46:44Z

@pytorchbot cherry-pick --onto release/2.4 -c critical --fixes #130659

Fixes #130659 Co-authored-by: Yu, Guangye <[email protected]> Pull Request resolved: #130660 Approved by: https://github.com/guangyey, https://github.com/fegin, https://github.com/albanD (cherry picked from commit bb62e9d)

pytorchbot · 2024-08-15T17:50:54Z

Cherry picking #130660

The cherry pick PR is at #133591 and it is linked with issue #130659. The following tracker issues are updated:

[v2.4.1] Release Tracker #132400 (comment)

Details for Dev Infra team

Raised by workflow job

Fixes pytorch#130659 Co-authored-by: Yu, Guangye <[email protected]> Pull Request resolved: pytorch#130660 Approved by: https://github.com/guangyey, https://github.com/fegin, https://github.com/albanD

Fixes #130659 Co-authored-by: Yu, Guangye <[email protected]> Pull Request resolved: #130660 Approved by: https://github.com/guangyey, https://github.com/fegin, https://github.com/albanD Co-authored-by: Adrian Wälchli <[email protected]>

…30660) (pytorch#134057)" This reverts commit 4ebe5b7.

Avoid autocast warning in data-parallel

490157c

awaelchli requested review from albanD, jbschlosser and mikaylagawarecki as code owners July 13, 2024 01:09

pytorch-bot bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Jul 13, 2024

pytorchbot added the open source label Jul 13, 2024

bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 13, 2024

guangyey reviewed Jul 16, 2024

View reviewed changes

torch/nn/parallel/parallel_apply.py Outdated Show resolved Hide resolved

guangyey mentioned this pull request Jul 16, 2024

Internal uses of torch.cuda.amp.autocast raise FutureWarnings #130659

Closed

Update torch/nn/parallel/parallel_apply.py

a16919d

Co-authored-by: Yu, Guangye <[email protected]>

guangyey approved these changes Jul 16, 2024

View reviewed changes

awaelchli commented Jul 16, 2024

View reviewed changes

torch/nn/parallel/parallel_apply.py Outdated Show resolved Hide resolved

Update torch/nn/parallel/parallel_apply.py

d1f3060

fegin added ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Jul 16, 2024

fegin approved these changes Jul 16, 2024

View reviewed changes

albanD approved these changes Jul 16, 2024

View reviewed changes

Merge branch 'main' into bugfix-autocast-warning

3e1db67

pytorchmergebot added the merging label Jul 17, 2024

pytorchmergebot removed the merging label Jul 17, 2024

guangyey added the topic: not user facing topic category label Jul 17, 2024

pytorchmergebot added the merging label Jul 17, 2024

pytorchmergebot added the Merged label Jul 17, 2024

pytorchmergebot closed this in bb62e9d Jul 17, 2024

pytorchmergebot removed the merging label Jul 17, 2024

awaelchli deleted the bugfix-autocast-warning branch July 17, 2024 09:07

pytorchbot mentioned this pull request Aug 15, 2024

[v2.4.1] Release Tracker #132400

Closed

atalman mentioned this pull request Aug 20, 2024

Avoid autocast deprecation warning in DataParallel (#130660) #134057

Merged

atalman added a commit to atalman/pytorch that referenced this pull request Aug 22, 2024

Revert "Avoid autocast deprecation warning in DataParallel (pytorch#1…

a070ee0

…30660) (pytorch#134057)" This reverts commit 4ebe5b7.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Avoid autocast deprecation warning in DataParallel #130660

Avoid autocast deprecation warning in DataParallel #130660

Uh oh!

awaelchli commented Jul 13, 2024 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Jul 13, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

awaelchli commented Jul 17, 2024 •

edited

Loading

Uh oh!

guangyey commented Jul 17, 2024

Uh oh!

pytorchmergebot commented Jul 17, 2024

Uh oh!

guangyey commented Jul 17, 2024

Uh oh!

pytorchmergebot commented Jul 17, 2024

Uh oh!

atalman commented Aug 15, 2024

Uh oh!

pytorchbot commented Aug 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Avoid autocast deprecation warning in DataParallel #130660

Avoid autocast deprecation warning in DataParallel #130660

Uh oh!

Conversation

awaelchli commented Jul 13, 2024 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jul 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130660

❌ 1 New Failure, 1 Cancelled Job, 1 Unrelated Failure

Uh oh!

Uh oh!

Uh oh!

awaelchli commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guangyey commented Jul 17, 2024

Uh oh!

pytorchmergebot commented Jul 17, 2024

Merge failed

Uh oh!

guangyey commented Jul 17, 2024

Uh oh!

pytorchmergebot commented Jul 17, 2024

Merge started

Uh oh!

atalman commented Aug 15, 2024

Uh oh!

pytorchbot commented Aug 15, 2024

Cherry picking #130660

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

awaelchli commented Jul 13, 2024 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Jul 13, 2024 •

edited

Loading

awaelchli commented Jul 17, 2024 •

edited

Loading