[Intel GPU]Add XPU into device list of cdist_impl
#130412
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 10, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130412
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit bce8e21 with merge base c9f1db2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ZhiweiYan-96
changed the title
ZhiweiYan-96
added
ciflow/xpu
EikanWang
approved these changes
Jul 15, 2024
ZhiweiYan-96
added a commit
that referenced
this pull request
Jul 16, 2024
ZhiweiYan-96
changed the title
cdist_impl
ZhiweiYan-96
added a commit
that referenced
this pull request
Jul 19, 2024
ZhiweiYan-96
added a commit
that referenced
this pull request
Jul 23, 2024
ZhiweiYan-96
added a commit
that referenced
this pull request
Jul 26, 2024
ZhiweiYan-96
added a commit
that referenced
this pull request
Jul 26, 2024
ZhiweiYan-96
added a commit
that referenced
this pull request
Aug 3, 2024
ZhiweiYan-96
added a commit
that referenced
this pull request
Aug 5, 2024
Collaborator
|
@ZhiweiYan-96 , Is this PR still valid? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
cdistcallscdist_stubfor each backend. However, solely using REGISTER_XPU_DISPATCH could not goes intocdist_stubsince there is another device list incdist_implfunc and XPU is not in it.This PR add XPU device into the supported list of
cdist_implso as to allow calling xpu kernel viacdist_stubStack from ghstack (oldest at bottom):
cdist_impl#130412cc @gujinghui @EikanWang @fengyuan14 @guangyey