Skip to content

fix discrepancy from the export of #126601 #130296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
izaitsevfb wants to merge 2 commits into from
Closed

fix discrepancy from the export of #126601 #130296

izaitsevfb wants to merge 2 commits into from

Conversation

@izaitsevfb
Copy link
Contributor

@izaitsevfb izaitsevfb commented Jul 8, 2024

#126601 (internally D58103182) was exported missing one class definition. This PR brings github repo in sync with fbcode.

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 8, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130296

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 86296c8 with merge base c6cce97 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: distributed (c10d) release notes category label Jul 8, 2024
@izaitsevfb izaitsevfb added the topic: not user facing topic category label Jul 8, 2024
@izaitsevfb izaitsevfb requested review from a team and d4l3k July 8, 2024 23:56
malfet
malfet approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it ninja-landed?

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 9, 2024

@izaitsevfb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@izaitsevfb
Copy link
Contributor Author

izaitsevfb commented Jul 9, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 9, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 9, 2024

Successfully rebased fix-discrepancy-export-126601 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix-discrepancy-export-126601 && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the fix-discrepancy-export-126601 branch from 297dc27 to 86296c8 Compare July 9, 2024 22:03
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 10, 2024

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 10, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
@izaitsevfb @xuhancn
fix discrepancy from the export of pytorch#126601 (pytorch#130296)
7395333 
pytorch#126601 (internally [D58103182](https://www.internalfb.com/diff/D58103182)) was exported missing one class definition. This PR brings github repo in sync with fbcode.
Pull Request resolved: pytorch#130296
Approved by: https://github.com/kit1980, https://github.com/seemethere, https://github.com/malfet
@github-actions github-actions bot deleted the fix-discrepancy-export-126601 branch August 10, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seemethere seemethere seemethere approved these changes

@malfet malfet malfet approved these changes

@d4l3k d4l3k Awaiting requested review from d4l3k

+1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged release notes: distributed (c10d) release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@izaitsevfb @facebook-github-bot @pytorchmergebot @kit1980 @seemethere @malfet