[custom_ops] expose torch.library.register_torch_dispatch #130261

zou3519 · 2024-07-08T18:34:10Z

Stack from ghstack (oldest at bottom):

This is the API for defining the interaction between a torch_dispatch
class and a custom op. Taking API bikeshedding.

Test Plan:

new tests

This is the API for defining the interaction between a torch_dispatch class and a custom op. Taking API bikeshedding. Test Plan: - new tests [ghstack-poisoned]

pytorch-bot · 2024-07-08T18:34:13Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130261

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 99a25c6 with merge base 9c1ba5a ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This is the API for defining the interaction between a torch_dispatch class and a custom op. Taking API bikeshedding. Test Plan: - new tests [ghstack-poisoned]

torch/library.py

This is the API for defining the interaction between a torch_dispatch class and a custom op. Taking API bikeshedding. Test Plan: - new tests [ghstack-poisoned]

albanD

Sounds good!
Only small nits on the doc

docs/source/notes/extending.rst

This is the API for defining the interaction between a torch_dispatch class and a custom op. Taking API bikeshedding. Test Plan: - new tests [ghstack-poisoned]

albanD · 2024-07-08T22:35:40Z

Ho we also remove positional? lol good to know!

zou3519 · 2024-07-08T22:36:47Z

Ho we also remove positional? lol good to know!

Yes, I'm not a big fan lol

This is the API for defining the interaction between a torch_dispatch class and a custom op. Taking API bikeshedding. Test Plan: - new tests [ghstack-poisoned]

This is the API for defining the interaction between a torch_dispatch class and a custom op. Taking API bikeshedding. Test Plan: - new tests ghstack-source-id: e4a9378 Pull Request resolved: #130261

zou3519 · 2024-07-09T20:22:10Z

@pytorchbot merge

pytorchmergebot · 2024-07-09T20:23:48Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

izaitsevfb · 2024-07-10T21:11:08Z

@pytorchbot revert -m "depends on #130064 which needs to be reverted" -c ghfirst

pytorchmergebot · 2024-07-10T21:12:39Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2024-07-10T21:12:49Z

Reverting PR 130261 failed

Reason: Command git -C /home/runner/work/pytorch/pytorch revert --no-edit bb9a73f767526e0d23c60360db5212b6bed0e8bc returned non-zero exit code 1

Auto-merging docs/source/library.rst
CONFLICT (content): Merge conflict in docs/source/library.rst
Auto-merging test/test_custom_ops.py
Auto-merging torch/library.py
error: could not revert bb9a73f767... [custom_ops] expose torch.library.register_torch_dispatch (#130261)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git revert --continue".
hint: You can instead skip this commit with "git revert --skip".
hint: To abort and get back to the state before "git revert",
hint: run "git revert --abort".
hint: Disable this message with "git config advice.mergeConflict false"

Details for Dev Infra team

Raised by workflow job

izaitsevfb · 2024-07-10T21:41:18Z

@pytorchbot revert -m "depends on #130064 which needs to be reverted" -c ghfirst

pytorchmergebot · 2024-07-10T21:43:19Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2024-07-10T21:43:30Z

@zou3519 your PR has been successfully reverted.

…30261)" This reverts commit bb9a73f. Reverted #130261 on behalf of https://github.com/izaitsevfb due to depends on #130064 which needs to be reverted ([comment](#130261 (comment)))

This is the API for defining the interaction between a torch_dispatch class and a custom op. Taking API bikeshedding. Test Plan: - new tests [ghstack-poisoned]

zou3519 · 2024-07-11T21:23:32Z

@pytorchbot merge -f "unrelated failure"

pytorchmergebot · 2024-07-11T21:25:10Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-07-11T21:25:24Z

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 9ac3d7f24c6d99762408e43526711495af0fd47b returned non-zero exit code 1

Auto-merging docs/source/library.rst
CONFLICT (content): Merge conflict in docs/source/library.rst
Auto-merging test/test_custom_ops.py
Auto-merging torch/_library/custom_ops.py
Auto-merging torch/library.py
error: could not apply 9ac3d7f24c... [custom_ops] expose torch.library.register_torch_dispatch (#130261)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

Details for Dev Infra team

Raised by workflow job

This is the API for defining the interaction between a torch_dispatch class and a custom op. Taking API bikeshedding. Test Plan: - new tests [ghstack-poisoned]

zou3519 · 2024-07-12T14:05:35Z

@pytorchbot merge

pytorchmergebot · 2024-07-12T14:07:26Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

This is the API for defining the interaction between a torch_dispatch class and a custom op. Taking API bikeshedding. Test Plan: - new tests Pull Request resolved: pytorch/pytorch#130261 Approved by: https://github.com/albanD ghstack dependencies: #130064 ghstack-source-id: 0b9c65a

…0261) This is the API for defining the interaction between a torch_dispatch class and a custom op. Taking API bikeshedding. Test Plan: - new tests Pull Request resolved: pytorch#130261 Approved by: https://github.com/albanD ghstack dependencies: pytorch#130064

…torch#130261)" This reverts commit bb9a73f. Reverted pytorch#130261 on behalf of https://github.com/izaitsevfb due to depends on pytorch#130064 which needs to be reverted ([comment](pytorch#130261 (comment)))

…0261) This is the API for defining the interaction between a torch_dispatch class and a custom op. Taking API bikeshedding. Test Plan: - new tests Pull Request resolved: pytorch#130261 Approved by: https://github.com/albanD ghstack dependencies: pytorch#130064

[custom_ops] expose torch.library.register_torch_dispatch

96cbad0

This is the API for defining the interaction between a torch_dispatch class and a custom op. Taking API bikeshedding. Test Plan: - new tests [ghstack-poisoned]

zou3519 mentioned this pull request Jul 8, 2024

Add API for open registration between operators and subclasses (and modes) #130064

Closed

zou3519 requested review from albanD and bdhirsh July 8, 2024 19:08

Update on "[custom_ops] expose torch.library.register_torch_dispatch"

df5d492

This is the API for defining the interaction between a torch_dispatch class and a custom op. Taking API bikeshedding. Test Plan: - new tests [ghstack-poisoned]

zou3519 commented Jul 8, 2024

View reviewed changes

torch/library.py Show resolved Hide resolved

Update on "[custom_ops] expose torch.library.register_torch_dispatch"

10aba88

This is the API for defining the interaction between a torch_dispatch class and a custom op. Taking API bikeshedding. Test Plan: - new tests [ghstack-poisoned]

zou3519 requested a review from soulitzer July 8, 2024 21:23

zou3519 added the release notes: composability release notes category label Jul 8, 2024

albanD approved these changes Jul 8, 2024

View reviewed changes

docs/source/notes/extending.rst Outdated Show resolved Hide resolved

docs/source/notes/extending.rst Outdated Show resolved Hide resolved

zou3519 added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 8, 2024

Update on "[custom_ops] expose torch.library.register_torch_dispatch"

13653d4

This is the API for defining the interaction between a torch_dispatch class and a custom op. Taking API bikeshedding. Test Plan: - new tests [ghstack-poisoned]

Update on "[custom_ops] expose torch.library.register_torch_dispatch"

5c52a7a

This is the API for defining the interaction between a torch_dispatch class and a custom op. Taking API bikeshedding. Test Plan: - new tests [ghstack-poisoned]

Update on "[custom_ops] expose torch.library.register_torch_dispatch"

48a1ca3

This is the API for defining the interaction between a torch_dispatch class and a custom op. Taking API bikeshedding. Test Plan: - new tests [ghstack-poisoned]

Update on "[custom_ops] expose torch.library.register_torch_dispatch"

ef6d4c1

This is the API for defining the interaction between a torch_dispatch class and a custom op. Taking API bikeshedding. Test Plan: - new tests [ghstack-poisoned]

pytorchmergebot added the merging label Jul 9, 2024

pytorchmergebot added the Merged label Jul 9, 2024

pytorchmergebot added the Reverted label Jul 10, 2024

pytorchmergebot reopened this Jul 10, 2024

Update on "[custom_ops] expose torch.library.register_torch_dispatch"

1f12932

This is the API for defining the interaction between a torch_dispatch class and a custom op. Taking API bikeshedding. Test Plan: - new tests [ghstack-poisoned]

pytorchmergebot added the merging label Jul 11, 2024

pytorchmergebot removed the merging label Jul 11, 2024

Update on "[custom_ops] expose torch.library.register_torch_dispatch"

99a25c6

This is the API for defining the interaction between a torch_dispatch class and a custom op. Taking API bikeshedding. Test Plan: - new tests [ghstack-poisoned]

pytorchmergebot added the merging label Jul 12, 2024

pytorchmergebot closed this in 9c69684 Jul 12, 2024

pytorchmergebot removed the merging label Jul 12, 2024

zou3519 mentioned this pull request Jul 12, 2024

[custom_op] triton_op API V0 #130637

Closed

henrylhtsang mentioned this pull request Jul 17, 2024

[aoti] Unskip some aot inductor tests #130973

Closed

[custom_ops] expose torch.library.register_torch_dispatch #130261

[custom_ops] expose torch.library.register_torch_dispatch #130261

Uh oh!

Conversation

zou3519 commented Jul 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jul 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130261

✅ No Failures

Uh oh!

Uh oh!

albanD left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

albanD commented Jul 8, 2024

Uh oh!

zou3519 commented Jul 8, 2024

Uh oh!

zou3519 commented Jul 9, 2024

Uh oh!

pytorchmergebot commented Jul 9, 2024

Merge started

Uh oh!

izaitsevfb commented Jul 10, 2024

Uh oh!

pytorchmergebot commented Jul 10, 2024

Uh oh!

pytorchmergebot commented Jul 10, 2024

Reverting PR 130261 failed

Uh oh!

izaitsevfb commented Jul 10, 2024

Uh oh!

pytorchmergebot commented Jul 10, 2024

Uh oh!

pytorchmergebot commented Jul 10, 2024

Uh oh!

zou3519 commented Jul 11, 2024

Uh oh!

pytorchmergebot commented Jul 11, 2024

Merge started

Uh oh!

pytorchmergebot commented Jul 11, 2024

Merge failed

Uh oh!

zou3519 commented Jul 12, 2024

Uh oh!

pytorchmergebot commented Jul 12, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zou3519 commented Jul 8, 2024 •

edited

Loading

pytorch-bot bot commented Jul 8, 2024 •

edited

Loading