Skip to content

Conversation

@clee2000
Copy link
Contributor

@clee2000 clee2000 commented Jul 5, 2024

@clee2000 clee2000 added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 5, 2024
@clee2000 clee2000 marked this pull request as ready for review July 5, 2024 17:18
@clee2000 clee2000 requested a review from a team as a code owner July 5, 2024 17:18
@clee2000 clee2000 changed the title [experiment] pin optree on windows Pin optree==0.11.0 on windows CI Jul 5, 2024
@clee2000 clee2000 added ciflow/trunk Trigger trunk jobs on your pull request and removed ciflow/trunk Trigger trunk jobs on your pull request labels Jul 5, 2024
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jul 5, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130155

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit d0665a6 with merge base a33ee73 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pushd "${PYTORCH_FINAL_PACKAGE_DIR}"
# shellcheck disable=SC2046,SC2102
python3 -mpip install $(echo *.whl)[opt-einsum,optree]
python3 -mpip install $(echo *.whl)[opt-einsum,optree==0.11.0]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should need to pin the version in setup.py.

@clee2000
Copy link
Contributor Author

clee2000 commented Jul 5, 2024

@pytorchbot merge -f "the things I care about on win passed"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Jul 15, 2024
0.12.0 Major Updates:

- Add context manager to temporarily set the dictionary sorting mode
- Add accessor APIs
- Use `stable` tag for `pybind11` for Python 3.13 support
- Fix potential segmentation fault for pickling support

0.12.1 Updates:

- Fix warning regression during import when launch with strict warning filters

Closes #130155
Pull Request resolved: #130139
Approved by: https://github.com/zou3519
pytorchmergebot pushed a commit that referenced this pull request Jul 20, 2024
0.12.0 Major Updates:

- Add context manager to temporarily set the dictionary sorting mode
- Add accessor APIs
- Use `stable` tag for `pybind11` for Python 3.13 support
- Fix potential segmentation fault for pickling support

0.12.1 Updates:

- Fix warning regression during import when launch with strict warning filters

Closes #130155
Pull Request resolved: #130139
Approved by: https://github.com/zou3519
ghstack dependencies: #130895
DiweiSun pushed a commit to DiweiSun/pytorch that referenced this pull request Jul 22, 2024
0.12.0 Major Updates:

- Add context manager to temporarily set the dictionary sorting mode
- Add accessor APIs
- Use `stable` tag for `pybind11` for Python 3.13 support
- Fix potential segmentation fault for pickling support

0.12.1 Updates:

- Fix warning regression during import when launch with strict warning filters

Closes pytorch#130155
Pull Request resolved: pytorch#130139
Approved by: https://github.com/zou3519
ghstack dependencies: pytorch#130895
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
0.12.0 Major Updates:

- Add context manager to temporarily set the dictionary sorting mode
- Add accessor APIs
- Use `stable` tag for `pybind11` for Python 3.13 support
- Fix potential segmentation fault for pickling support

0.12.1 Updates:

- Fix warning regression during import when launch with strict warning filters

Closes pytorch#130155
Pull Request resolved: pytorch#130139
Approved by: https://github.com/zou3519
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
0.12.0 Major Updates:

- Add context manager to temporarily set the dictionary sorting mode
- Add accessor APIs
- Use `stable` tag for `pybind11` for Python 3.13 support
- Fix potential segmentation fault for pickling support

0.12.1 Updates:

- Fix warning regression during import when launch with strict warning filters

Closes pytorch#130155
Pull Request resolved: pytorch#130139
Approved by: https://github.com/zou3519
ghstack dependencies: pytorch#130895
@github-actions github-actions bot deleted the csl/pin_optree_win branch August 5, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants