[pytree][Easy] preserve dict keys in insertion order in CXX pytree
#130140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130140
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c21880a with merge base 6a9a02a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jul 5, 2024
XuehaiPan
added
module: pytree
ciflow/trunk
XuehaiPan
changed the title
dict keys in insertion order in CXX pytreedict keys in insertion order in CXX pytree
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jan 9, 2025
ghstack-source-id: e37db61 Pull Request resolved: pytorch#130140
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jan 10, 2025
ghstack-source-id: 813b328 Pull Request resolved: pytorch#130140
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Feb 4, 2025
ghstack-source-id: 782fe2b Pull Request resolved: pytorch#130140
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Feb 9, 2025
ghstack-source-id: 50a63f4 Pull Request resolved: pytorch#130140
XuehaiPan
commented
Feb 11, 2025
Comment on lines
+64
to
+65
| __TORCH_DICT_SESSION = optree.dict_insertion_ordered(True, namespace="torch") | ||
| __TORCH_DICT_SESSION.__enter__() # enable globally and permanently |
Contributor
There was a problem hiding this comment.
If you're sure about this. The fun thing is if someone imports torch cxx_pytree and uses optree then they will override the optree behavior
Collaborator
Author
There was a problem hiding this comment.
It only affects optree functions that passed with namespace="torch".
zou3519
approved these changes
Feb 12, 2025
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optreeand JAX pytree traversal thedictin sorted key ordering (see Key Ordering for Dictionaries). While in PyTorch Python pytree, we traversal thedictin insertion order. See also:dicts do not imply equal leaves and equal treespecs #114392This aligns the behavior of CXX pytree with Python pytree.
Stack from ghstack (oldest at bottom):
torch.utils.pytreeby default #138056torch.distributed#144332torch.func#137884torch.utils._pytree->torch.utils.pytree.python#144405torch.utils.pytree#137400dictkeys in insertion order in CXX pytree #130140cc @zou3519