[BE] bump optree version to 0.12.1
#130139
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130139
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled JobAs of commit f559691 with merge base 3c622fb ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jul 5, 2024
XuehaiPan
added
release notes: releng
Contributor
|
Please also pin optree in windows CI pytorch/.github/workflows/_win-test.yml Line 191 in a33ee73 The update to 0.12.0 got picked up and is currently failing. I have #130155 to pin it to 0.11.0 to restore the current CI if this takes too long to merge |
XuehaiPan
commented
Jul 5, 2024
| >>> tree = OrderedDict([('b', (2, [3, 4])), ('a', 1), ('c', None), ('d', 5)]) | ||
| >>> tree_flatten(tree) | ||
| ([2, 3, 4, 1, None, 5], PyTreeSpec(OrderedDict([('b', (*, [*, *])), ('a', *), ('c', *), ('d', *)]), NoneIsLeaf)) | ||
| ([2, 3, 4, 1, None, 5], PyTreeSpec(OrderedDict({'b': (*, [*, *]), 'a': *, 'c': *, 'd': *}), NoneIsLeaf)) |
Collaborator
Author
There was a problem hiding this comment.
The update to 0.12.0 got picked up and is currently failing.
@clee2000 The doctest fix is included.
XuehaiPan
changed the title
optree version to 0.12.0optree version to 0.12.1
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 18, 2024
0.12.0 Major Updates: - Add context manager to temporarily set the dictionary sorting mode - Add accessor APIs - Use `stable` tag for `pybind11` for Python 3.13 support - Fix potential segmentation fault for pickling support 0.12.1 Updates: - Fix warning regression during import when launch with strict warning filters ghstack-source-id: c80bc58 Pull Request resolved: pytorch#130139
Collaborator
Author
Yes, it is tested against Python 3.13t. |
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 19, 2024
0.12.0 Major Updates: - Add context manager to temporarily set the dictionary sorting mode - Add accessor APIs - Use `stable` tag for `pybind11` for Python 3.13 support - Fix potential segmentation fault for pickling support 0.12.1 Updates: - Fix warning regression during import when launch with strict warning filters ghstack-source-id: 473f570 Pull Request resolved: pytorch#130139
albanD
reviewed
Jul 19, 2024
Collaborator
Author
|
@pytorchbot merge -i |
Collaborator
Merge startedYour change will be merged while ignoring the following 1 checks: Mac MPS / macos-py3-arm64-mps / test (mps, 1, 1, macos-m2-14) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 21, 2024
Pull Request resolved: #130144 Approved by: https://github.com/zou3519 ghstack dependencies: #130895, #130139
DiweiSun
pushed a commit
to DiweiSun/pytorch
that referenced
this pull request
Jul 22, 2024
0.12.0 Major Updates: - Add context manager to temporarily set the dictionary sorting mode - Add accessor APIs - Use `stable` tag for `pybind11` for Python 3.13 support - Fix potential segmentation fault for pickling support 0.12.1 Updates: - Fix warning regression during import when launch with strict warning filters Closes pytorch#130155 Pull Request resolved: pytorch#130139 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#130895
DiweiSun
pushed a commit
to DiweiSun/pytorch
that referenced
this pull request
Jul 22, 2024
Pull Request resolved: pytorch#130144 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#130895, pytorch#130139
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Jul 25, 2024
0.12.0 Major Updates: - Add context manager to temporarily set the dictionary sorting mode - Add accessor APIs - Use `stable` tag for `pybind11` for Python 3.13 support - Fix potential segmentation fault for pickling support 0.12.1 Updates: - Fix warning regression during import when launch with strict warning filters Closes pytorch#130155 Pull Request resolved: pytorch#130139 Approved by: https://github.com/zou3519
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Jul 25, 2024
This reverts commit 8fcb156. Reverted pytorch#130139 on behalf of https://github.com/clee2000 due to broke inductor/test_torchinductor_codegen_dynamic_shapes.py and test_sympy_utils.py https://hud.pytorch.org/pytorch/pytorch/commit/8fcb156e8b5697a8f292db6db2a1803c5f4ce2d7 ([comment](pytorch#130139 (comment)))
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Jul 25, 2024
0.12.0 Major Updates: - Add context manager to temporarily set the dictionary sorting mode - Add accessor APIs - Use `stable` tag for `pybind11` for Python 3.13 support - Fix potential segmentation fault for pickling support 0.12.1 Updates: - Fix warning regression during import when launch with strict warning filters Closes pytorch#130155 Pull Request resolved: pytorch#130139 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#130895
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Jul 25, 2024
Pull Request resolved: pytorch#130144 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#130895, pytorch#130139
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
dictkeys in insertion order in CXX pytree #130140torch::deploy#130144optreeversion to 0.12.1 #130139sympy >= 1.13.0#1308950.12.0 Major Updates:
stabletag forpybind11for Python 3.13 support0.12.1 Updates:
Closes #130155