Skip to content

[reland][custom ops] infer schema #130079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yushangdi wants to merge 14 commits into from
Closed

[reland][custom ops] infer schema #130079

yushangdi wants to merge 14 commits into from

Conversation

@yushangdi
Copy link
Contributor

@yushangdi yushangdi commented Jul 4, 2024

Fixes #129617

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130079

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 80f0e4e with merge base 86bca69 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@yushangdi yushangdi changed the title infer schema [custom ops] infer schema Jul 4, 2024
@yushangdi yushangdi requested a review from zou3519 July 4, 2024 01:19
zou3519
zou3519 reviewed Jul 5, 2024
View reviewed changes
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename to infer_schema, because that's what that function does. Public APIs need to have docstrings and documentation so let's add those as well.

zou3519
zou3519 reviewed Jul 5, 2024
View reviewed changes
@yushangdi yushangdi force-pushed the sy_lib_infer_schema branch from 1b7bee9 to 0aa21bf Compare July 5, 2024 20:14
@yushangdi yushangdi requested a review from zou3519 July 5, 2024 20:40
zou3519
zou3519 approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please make sure the doc renders (there's a docs preview if we wait long enough for CI)

@yushangdi yushangdi added module: custom-operators custom operators, custom ops, custom-operators, custom-ops ciflow/trunk Trigger trunk jobs on your pull request release notes: composability release notes category labels Jul 5, 2024
@yushangdi
Copy link
Contributor Author

yushangdi commented Jul 6, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 6, 2024

Merge started

Your change will be merged while ignoring the following 34 checks: Check Labels, pull / before-test / llm-retrieval, pull / linux-focal-py3.12-clang10 / test (default, 1, 4, linux.2xlarge), pull / linux-focal-py3.12-clang10 / test (default, 3, 4, linux.2xlarge), pull / linux-focal-py3.12-clang10 / test (dynamo, 1, 3, linux.2xlarge), pull / linux-focal-py3.8-clang10 / test (default, 1, 4, linux.2xlarge), pull / linux-focal-py3.8-clang10 / test (default, 3, 4, linux.2xlarge), pull / linux-focal-py3.8-clang10 / test (crossref, 1, 2, linux.2xlarge), pull / linux-focal-py3.8-clang10 / test (crossref, 2, 2, linux.2xlarge), pull / linux-focal-py3.8-clang10 / test (dynamo, 1, 3, linux.2xlarge), pull / linux-focal-py3.12-clang10-experimental-split-build / test (default, 1, 3, linux.2xlarge, unstable), pull / linux-focal-py3.12-clang10-experimental-split-build / test (default, 3, 3, linux.2xlarge, unstable), pull / linux-focal-py3.12-clang10-experimental-split-build / test (dynamo, 1, 3, linux.2xlarge, unstable), pull / linux-focal-py3.11-clang10 / test (default, 1, 4, linux.2xlarge), pull / linux-focal-py3.11-clang10 / test (default, 3, 4, linux.2xlarge), pull / linux-focal-py3.11-clang10 / test (crossref, 1, 2, linux.2xlarge), pull / linux-focal-py3.11-clang10 / test (crossref, 2, 2, linux.2xlarge), pull / linux-focal-py3.11-clang10 / test (dynamo, 1, 3, linux.2xlarge), pull / linux-jammy-py3.8-gcc11 / test (default, 1, 4, linux.2xlarge), pull / linux-jammy-py3.8-gcc11 / test (default, 3, 4, linux.2xlarge), pull / linux-jammy-py3.10-clang15-asan / test (default, 1, 6, linux.4xlarge), pull / linux-jammy-py3.10-clang15-asan / test (default, 3, 6, linux.4xlarge), pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 1, 5, linux.4xlarge.nvidia.gpu), pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 3, 5, linux.4xlarge.nvidia.gpu), pull / linux-focal-cuda12.1-py3.10-gcc9-experimental-split-build / test (default, 1, 5, linux.4xlarge.nvidia.gpu, unstable), pull / linux-focal-cuda12.1-py3.10-gcc9-experimental-split-build / test (default, 3, 5, linux.4xlarge.nvidia.gpu, unstable), pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 1, 5, linux.g5.4xlarge.nvidia.gpu), pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 3, 5, linux.g5.4xlarge.nvidia.gpu), trunk / macos-py3-arm64 / test (default, 1, 3, macos-m1-stable), trunk / win-vs2019-cpu-py3 / test (default, 2, 3, windows.4xlarge.nonephemeral), trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (nogpu_AVX512, 1, 1, linux.2xlarge), trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (nogpu_NO_AVX2, 1, 1, linux.2xlarge), trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (default, 3, 5, linux.4xlarge.nvidia.gpu), trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 2, 5, linux.g5.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 6, 2024

Merge failed

Reason: 13 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@yushangdi
Copy link
Contributor Author

yushangdi commented Jul 8, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 8, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 8, 2024

Tried to rebase and push PR #130079, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

@yushangdi
Copy link
Contributor Author

yushangdi commented Jul 8, 2024

@pytorchbot merge -f "unrelated failures in broken trunk"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 8, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn
Copy link
Contributor

huydhn commented Jul 8, 2024

@pytorchbot revert -m 'The test_public_bindings failure looks legit https://hud.pytorch.org/pytorch/pytorch/commit/3fe324ffb612c8712f6af7639c1e7bcec5f3b4fd' -c weird

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 8, 2024

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Jul 8, 2024
@pytorchmergebot
Revert "[custom ops] infer schema (#130079)"
44a773c 
This reverts commit 3fe324f.

Reverted #130079 on behalf of https://github.com/huydhn due to The test_public_bindings failure looks legit https://hud.pytorch.org/pytorch/pytorch/commit/3fe324ffb612c8712f6af7639c1e7bcec5f3b4fd ([comment](#130079 (comment)))
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 8, 2024

@yushangdi your PR has been successfully reverted.

@yushangdi
Copy link
Contributor Author

yushangdi commented Jul 9, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 9, 2024

Merge started

Your change will be merged while ignoring the following 0 checks:

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 10, 2024

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (default, 5, 5, linux.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@yushangdi
Copy link
Contributor Author

yushangdi commented Jul 10, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 10, 2024

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (default, 5, 5, linux.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@izaitsevfb
Copy link
Contributor

izaitsevfb commented Jul 10, 2024

@pytorchbot revert -m "depends on #130064 which needs to be reverted" -c ghfirst

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 10, 2024

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 10, 2024

@yushangdi your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Jul 10, 2024
@pytorchmergebot
Revert "[reland][custom ops] infer schema (#130079)"
e14a0f4 
This reverts commit bef085b.

Reverted #130079 on behalf of https://github.com/izaitsevfb due to depends on #130064 which needs to be reverted ([comment](#130079 (comment)))
@yushangdi
Copy link
Contributor Author

yushangdi commented Jul 10, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 10, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@zou3519
Copy link
Contributor

zou3519 commented Jul 10, 2024

@yushangdi I am going to hold off on re-merging #130064 until this goes in, that one will take some more time to fix

@henrylhtsang henrylhtsang mentioned this pull request Jul 17, 2024
Closed
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
@yushangdi @xuhancn
[reland][custom ops] infer schema (pytorch#130079)
134135f 
Fixes pytorch#129617

Pull Request resolved: pytorch#130079
Approved by: https://github.com/zou3519
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
@pytorchmergebot @xuhancn
Revert "[reland][custom ops] infer schema (pytorch#130079)"
b6c9982 
This reverts commit bef085b.

Reverted pytorch#130079 on behalf of https://github.com/izaitsevfb due to depends on pytorch#130064 which needs to be reverted ([comment](pytorch#130079 (comment)))
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
@yushangdi @xuhancn
[reland][custom ops] infer schema (pytorch#130079)
0d33577 
Fixes pytorch#129617

Pull Request resolved: pytorch#130079
Approved by: https://github.com/zou3519
@github-actions github-actions bot deleted the sy_lib_infer_schema branch August 12, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request Merged module: custom-operators custom operators, custom ops, custom-operators, custom-ops release notes: composability release notes category Reverted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[custom_op] torch.library.define should be able to auto-infer schema.

7 participants

@yushangdi @pytorchmergebot @huydhn @izaitsevfb @zou3519 @clee2000