Skip to content

[BE][Ez]: Update pybind11 submodule to v2.13.1 #129827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Skylion007 wants to merge 1 commit into from
Closed

[BE][Ez]: Update pybind11 submodule to v2.13.1 #129827

Skylion007 wants to merge 1 commit into from

Conversation

@Skylion007
Copy link
Collaborator

@Skylion007 Skylion007 commented Jun 29, 2024

Updates pybind11 submodule to v2.13.1

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 29, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129827

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit cc7ece5 with merge base 6f275ae (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 29, 2024
@Skylion007 Skylion007 added better-engineering Relatively self-contained tasks for better engineering contributors open source labels Jun 29, 2024
@XuehaiPan XuehaiPan added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 30, 2024
@Skylion007 Skylion007 requested review from albanD, ezyang and malfet June 30, 2024 16:33
albanD
albanD approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM
What are the notable additions in this version? Is it NoGil safe?

@Skylion007
Copy link
Collaborator Author

Skylion007 commented Jul 2, 2024

We have preliminary support for it: "Support free-threaded CPython (3.13t). Add py::mod_gil_not_used() tag to indicate if a module supports running with the GIL disabled. pybind/pybind11#5148"

@Skylion007
Copy link
Collaborator Author

Skylion007 commented Jul 2, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 2, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@XuehaiPan XuehaiPan self-requested a review July 2, 2024 17:40
XuehaiPan
XuehaiPan requested changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@XuehaiPan XuehaiPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should wait for a new stable release after pybind/pybind11#5208 is backported.

@albanD
Copy link
Collaborator

albanD commented Jul 2, 2024

Updating this pin is pretty cheap on our end. So I wouldn't say we must wait for the backport and full release if this doesn't break anything in PyTorch.
But feel free to do what is best!

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 2, 2024

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m1-14)

Details for Dev Infra team Raised by workflow job

@Skylion007 Skylion007 requested review from XuehaiPan and removed request for XuehaiPan July 2, 2024 19:39
@Skylion007
Copy link
Collaborator Author

Skylion007 commented Jul 2, 2024

@XuehaiPan We don't use the typing.h feature of pybind11 to my knowledge?

@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 3, 2024
@XuehaiPan
Copy link
Collaborator

XuehaiPan commented Jul 3, 2024

@XuehaiPan We don't use the typing.h feature of pybind11 to my knowledge?

#include <pybind11/pybind11> includes #include <pybind11/typing.h>

https://github.com/pybind/pybind11/blob/bb05e0810b87e74709d9f4c4545f1f57a1b386f5/include/pybind11/pybind11.h#L19

It breaks gcc-14 build even if we are not using the typing feature.

@Skylion007
Copy link
Collaborator Author

Skylion007 commented Jul 14, 2024

@XuehaiPan We are going to need to update to unblock 3.13 support

@albanD
Copy link
Collaborator

albanD commented Jul 14, 2024

FYI this is part of #130689 as well for 3.13. We can merge either first depending on how the Meta-side upgrade goes.

@XuehaiPan
Copy link
Collaborator

XuehaiPan commented Jul 15, 2024

@pytorchbot merge --rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 15, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 15, 2024

Successfully rebased skylion007/update-pybind11-v2-13-1 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout skylion007/update-pybind11-v2-13-1 && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the skylion007/update-pybind11-v2-13-1 branch from cf5b334 to cc7ece5 Compare July 15, 2024 04:03
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 15, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@Skylion007 Skylion007 deleted the skylion007/update-pybind11-v2-13-1 branch July 15, 2024 14:55
@henrylhtsang henrylhtsang mentioned this pull request Jul 17, 2024
Closed
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
@Skylion007 @xuhancn
[BE][Ez]: Update pybind11 submodule to v2.13.1 (pytorch#129827)
21c5285 
Updates pybind11 submodule to v2.13.1
Pull Request resolved: pytorch#129827
Approved by: https://github.com/XuehaiPan, https://github.com/atalman, https://github.com/albanD
@albanD albanD mentioned this pull request Aug 6, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@atalman atalman atalman approved these changes

@XuehaiPan XuehaiPan XuehaiPan approved these changes

@ezyang ezyang Awaiting requested review from ezyang

@malfet malfet Awaiting requested review from malfet

Assignees

No one assigned

Labels

better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Skylion007 @pytorchmergebot @albanD @XuehaiPan @atalman @soulitzer