Skip to content

Use absolute path path.resolve() -> path.absolute() #129409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
XuehaiPan wants to merge 32 commits into from
Closed

Use absolute path path.resolve() -> path.absolute() #129409

XuehaiPan wants to merge 32 commits into from

Conversation

@XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Jun 24, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Changes:

  1. Always explicit .absolute(): Path(__file__) -> Path(__file__).absolute()
  2. Replace path.resolve() with path.absolute() if the code is resolving the PyTorch repo root directory.

cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov @peterbell10

@XuehaiPan
Update
cc5485f 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 24, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129409

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 01870ec with merge base e141cb9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@XuehaiPan XuehaiPan mentioned this pull request Jun 24, 2024
Closed
This was referenced Jun 24, 2024
Closed
Closed
@XuehaiPan XuehaiPan added topic: not user facing topic category better-engineering Relatively self-contained tasks for better engineering contributors labels Jun 24, 2024
@XuehaiPan
Update
0d9a42e 
[ghstack-poisoned]
This was referenced Jun 24, 2024
Closed
Closed
@XuehaiPan
Update
fc73b46 
[ghstack-poisoned]
@XuehaiPan XuehaiPan mentioned this pull request Jun 25, 2024
Closed
@XuehaiPan
Update
1e15cc4 
[ghstack-poisoned]
@malfet
Copy link
Contributor

malfet commented Dec 26, 2024

@pytorchbot revert -m "need to revert to as dependency of #129374" -c nosignal

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 26, 2024

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 26, 2024

@XuehaiPan your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Dec 26, 2024
@pytorchmergebot
Revert "Use absolute path path.resolve() -> path.absolute() (#129409
cc4e70b 
)"

This reverts commit 135c7db.

Reverted #129409 on behalf of https://github.com/malfet due to need to revert to as dependency of #129374 ([comment](#129409 (comment)))
@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Dec 26, 2024
@XuehaiPan
Update
3f44af0 
[ghstack-poisoned]
@XuehaiPan
Update
b93e98d 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Dec 27, 2024
@XuehaiPan
Use absolute path path.resolve() -> path.absolute()
25bc4da 
ghstack-source-id: 05aac76
Pull Request resolved: #129409
@XuehaiPan
Update
449e7bb 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Dec 29, 2024
@XuehaiPan
Use absolute path path.resolve() -> path.absolute()
c88b7e5 
ghstack-source-id: 8363e9c
Pull Request resolved: #129409
@XuehaiPan
Update
01870ec 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Jan 3, 2025
@XuehaiPan
Use absolute path path.resolve() -> path.absolute()
d10013d 
ghstack-source-id: 1410448
Pull Request resolved: #129409
@XuehaiPan
Copy link
Collaborator Author

XuehaiPan commented Jan 3, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 3, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@jeanschmidt
Copy link
Contributor

jeanschmidt commented Jan 4, 2025

@pytorchbot revert -m "Breaking internal CI, @albanD please help get this PR merged" -c ghfirst

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 4, 2025

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Jan 4, 2025
@pytorchmergebot
Revert "Use absolute path path.resolve() -> path.absolute() (#129409
99f2491 
)"

This reverts commit 45411d1.

Reverted #129409 on behalf of https://github.com/jeanschmidt due to Breaking internal CI, @albanD please help get this PR merged ([comment](#129409 (comment)))
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 4, 2025

@XuehaiPan your PR has been successfully reverted.

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jan 6, 2025
@XuehaiPan
Use absolute path path.resolve() -> path.absolute()
749c0ae 
ghstack-source-id: 1410448
Pull Request resolved: pytorch#129409
atalman
atalman reviewed Jan 6, 2025
View reviewed changes
test/dynamo/test_cudagraphs_expandable_segments.py

sys.path.insert(0, str(REPO_ROOT))

from tools.stats.import_test_stats import get_disabled_tests
Copy link
Contributor

@atalman atalman Jan 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like internal failure on this line:
ModuleNotFoundError: No module named 'tools'

Copy link
Collaborator

@albanD albanD Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the path insert above doesn't work anymore.
cc @eellison why is this needed? We really shouldn't play with python path to find tests?

@github-actions github-actions bot closed this Feb 5, 2025
@github-actions github-actions bot deleted the gh/XuehaiPan/70/head branch March 8, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@atalman atalman atalman left review comments

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd

@andrewkho andrewkho Awaiting requested review from andrewkho

@gokulavasan gokulavasan Awaiting requested review from gokulavasan

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168

@divyanshk divyanshk Awaiting requested review from divyanshk

@titaiwangms titaiwangms Awaiting requested review from titaiwangms

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

@justinchuby justinchuby Awaiting requested review from justinchuby

@wschin wschin Awaiting requested review from wschin

@fmassa fmassa Awaiting requested review from fmassa

@soumith soumith Awaiting requested review from soumith

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

better-engineering Relatively self-contained tasks for better engineering contributors ci-no-td Do not run TD on this PR ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: inductor oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: quantization release notes category release notes: releng release notes category Reverted Stale topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@XuehaiPan @pytorchmergebot @malfet @jeanschmidt @albanD @atalman @pytorchbot