Skip to content

[Caffe2] [2/N] Remove Caffe2 from tests #128911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cyyever wants to merge 2 commits into from
Closed

[Caffe2] [2/N] Remove Caffe2 from tests #128911

cyyever wants to merge 2 commits into from

Conversation

@cyyever
Copy link
Collaborator

@cyyever cyyever commented Jun 17, 2024 •
edited
Loading

Follows #128675

@pytorch-bot pytorch-bot bot added release notes: quantization release notes category topic: not user facing topic category labels Jun 17, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 17, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128911

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 442fdef with merge base 8415a4b (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever changed the title Remove Caffe2 from tests [Caffe2] [2/N] Remove Caffe2 from tests Jun 17, 2024
titaiwangms
titaiwangms approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@titaiwangms titaiwangms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on ONNX side

@cyyever cyyever added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 18, 2024
@cyyever
Copy link
Collaborator Author

cyyever commented Jun 18, 2024

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 18, 2024

Merge failed

Reason: Approvers from one of the following sets are needed:

  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@cyyever cyyever requested a review from r-barnes June 18, 2024 14:05
@cyyever
Copy link
Collaborator Author

cyyever commented Jun 18, 2024

@r-barnes Help review it?

@r-barnes r-barnes added caffe2 topic: deprecation topic category topic: improvements topic category python Pull requests that update Python code labels Jun 18, 2024
@cyyever
Copy link
Collaborator Author

cyyever commented Jun 19, 2024

@pytorchmergebot merge -f "The CI failure is unrelated"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 19, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the caffe2_onnx5 branch June 19, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r-barnes r-barnes r-barnes approved these changes

@titaiwangms titaiwangms titaiwangms approved these changes

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

@justinchuby justinchuby Awaiting requested review from justinchuby justinchuby is a code owner

@wschin wschin Awaiting requested review from wschin

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168 jerryzh168 is a code owner

@albanD albanD Awaiting requested review from albanD albanD is a code owner

Assignees

No one assigned

Labels

caffe2 ciflow/trunk Trigger trunk jobs on your pull request Merged open source python Pull requests that update Python code release notes: quantization release notes category topic: deprecation topic category topic: improvements topic category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cyyever @pytorchmergebot @r-barnes @titaiwangms @pytorchbot