[1/N] [Caffe2] Remove caffe2_aten_fallback code #128675
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyyever
requested review from
a team,
BowenBao,
thiagocrepaldi and
wschin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128675
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New Failures, 1 Unrelated FailureAs of commit b8158e4 with merge base 43ae307 ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: onnx
cyyever
changed the title
cyyever
force-pushed
the
caffe2_aten_fallback
branch
from
4a601d5 to
25420a7
Compare
cyyever
force-pushed
the
caffe2_aten_fallback
branch
2 times, most recently
from
a8ef554 to
0fad1dc
Compare
cyyever
force-pushed
the
caffe2_aten_fallback
branch
4 times, most recently
from
9c2cf3b to
b8158e4
Compare
mikaylagawarecki
added
the
triaged
r-barnes
approved these changes
Jun 17, 2024
r-barnes
added
release notes: cpp
Contributor
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
Contributor
|
@pytorchbot merge -i |
Collaborator
Merge startedYour change will be merged while ignoring the following 2 checks: pull / linux-jammy-py3.8-gcc11 / test (distributed, 2, 2, linux.2xlarge), Lint / workflow-checks / linux-job Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This was referenced Nov 18, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 18, 2024
) Fixes #132205 Regression happened after #128675 that ONNX shape type inference error stops the exporting process during shape type inference. ONNX shape type inference during the export only does it's best to fulfill the information, and should not crash the export. Pull Request resolved: #140962 Approved by: https://github.com/justinchuby
cyyever
pushed a commit
to cyyever/pytorch
that referenced
this pull request
Nov 20, 2024
…rch#140962) Fixes pytorch#132205 Regression happened after pytorch#128675 that ONNX shape type inference error stops the exporting process during shape type inference. ONNX shape type inference during the export only does it's best to fulfill the information, and should not crash the export. Pull Request resolved: pytorch#140962 Approved by: https://github.com/justinchuby
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…rch#140962) Fixes pytorch#132205 Regression happened after pytorch#128675 that ONNX shape type inference error stops the exporting process during shape type inference. ONNX shape type inference during the export only does it's best to fulfill the information, and should not crash the export. Pull Request resolved: pytorch#140962 Approved by: https://github.com/justinchuby
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_NUMBER