Skip to content

[CUDA][Inductor][CI] Revert PR#127150 since cu124 is now behaving similar enough to cu121 #128423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nWEIdia wants to merge 2 commits into from
Closed

[CUDA][Inductor][CI] Revert PR#127150 since cu124 is now behaving similar enough to cu121 #128423

nWEIdia wants to merge 2 commits into from

Conversation

@nWEIdia
Copy link
Collaborator

@nWEIdia nWEIdia commented Jun 11, 2024 •
edited
Loading

Pre-requisite: close #126692 first.

This PR also gives a current read on cu121 and cu124 parity.

Essentially reverting #127150

cc @albanD @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @eqy @Fuzzkatt @ptrblck @atalman @malfet

@nWEIdia nWEIdia requested a review from a team as a code owner June 11, 2024 17:11
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 11, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128423

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (27 Unrelated Failures)

As of commit c47bd4b with merge base 795db80 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@nWEIdia nWEIdia added the ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR label Jun 11, 2024
@nWEIdia nWEIdia added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 11, 2024
@nWEIdia nWEIdia mentioned this pull request Jun 12, 2024
Closed
@nWEIdia nWEIdia mentioned this pull request Jun 13, 2024
Closed
@nWEIdia nWEIdia force-pushed the main-revert-PR127150 branch from 985847e to a6b2e5b Compare June 13, 2024 06:27
@nWEIdia nWEIdia added skip-pr-sanity-checks and removed ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Jun 13, 2024
@nWEIdia nWEIdia force-pushed the main-revert-PR127150 branch from a6b2e5b to 0b825a1 Compare June 13, 2024 16:37
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 13, 2024
@nWEIdia nWEIdia force-pushed the main-revert-PR127150 branch from 0b825a1 to a7adb99 Compare June 24, 2024 18:12
@nWEIdia nWEIdia added the ciflow/unstable Run all experimental or flaky jobs on PyTorch unstable workflow label Jun 24, 2024
@nWEIdia nWEIdia requested review from atalman, desertfire and malfet June 24, 2024 22:47
@nWEIdia nWEIdia changed the title [CUDA][Inductor][CI] Revert PR#127150 since cu124 should be parity with cu121 [CUDA][Inductor][CI] Revert PR#127150 since cu124 is now behaving similar enough to cu121 Jun 24, 2024
atalman
atalman approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nWEIdia nWEIdia force-pushed the main-revert-PR127150 branch from a7adb99 to 80e8308 Compare June 25, 2024 16:07
@nWEIdia
Copy link
Collaborator Author

nWEIdia commented Jun 25, 2024

@pytorchbot merge -f "required inductor signals are green and trunk is broken"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 25, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@nWEIdia nWEIdia mentioned this pull request Jun 26, 2024
Closed
@nWEIdia
Copy link
Collaborator Author

nWEIdia commented Jun 26, 2024

@pytorchbot revert -m 'Sorry for reverting your change but I need to revert it to cleanly revert #129374' -c weird

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 26, 2024

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Jun 26, 2024
@pytorchmergebot
Revert "[CUDA][Inductor][CI] Revert PR#127150 since cu124 is now beha…
e9aefad 
…ving similar enough to cu121 (#128423)"

This reverts commit 551e412.

Reverted #128423 on behalf of https://github.com/nWEIdia due to Sorry for reverting your change but I need to revert it to cleanly revert #129374 ([comment](#128423 (comment)))
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 26, 2024

@nWEIdia your PR has been successfully reverted.

@nWEIdia nWEIdia force-pushed the main-revert-PR127150 branch from 80e8308 to 55a7620 Compare June 26, 2024 20:43
@nWEIdia
Copy link
Collaborator Author

nWEIdia commented Jun 27, 2024

@pytorchbot merge -f "inductor cuda jobs are ok except broken trunk"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 27, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eqy eqy eqy approved these changes

@atalman atalman atalman approved these changes

@desertfire desertfire Awaiting requested review from desertfire

@malfet malfet Awaiting requested review from malfet

Assignees

No one assigned

Labels

ciflow/inductor ciflow/inductor-cu124 ciflow/trunk Trigger trunk jobs on your pull request ciflow/unstable Run all experimental or flaky jobs on PyTorch unstable workflow Merged module: dynamo open source Reverted skip-pr-sanity-checks triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CUDA 12.4 CI Inductor Issues

6 participants

@nWEIdia @pytorchmergebot @eqy @atalman @soulitzer @pytorchbot