[inductor] subproc parallel-compile: start thread last in init #128037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Observed on an internal workload: the helper thread started and attempted to access member variables before they were initialized. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128037
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (5 Unrelated Failures)As of commit 9f593ba with merge base 6e54539 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Skylion007
approved these changes
Jun 5, 2024
eellison
approved these changes
Jun 5, 2024
Contributor
Author
|
@pytorchbot rebase |
Collaborator
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Collaborator
|
Successfully rebased |
…init" Summary: Observed on an internal workload: the helper thread started and attempted to access member variables before they were initialized. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
Contributor
Author
|
@masnesral has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 7, 2024
… work to the pool (#128086) Summary: I got reports of intermittent failures in CI and the logs show errors like this: ``` CRITICAL:concurrent.futures:Future 139789013754560 in unexpected state: FINISHED ``` I can't repro locally, but seems clear that we should initialize the future _before_ sending work to the subprocess pool since it could finish before we call set_running_or_notify_cancel() Differential Revision: [D58239829](https://our.internmc.facebook.com/intern/diff/D58239829) Pull Request resolved: #128086 Approved by: https://github.com/jansel ghstack dependencies: #128037
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 7, 2024
…126817) Differential Revision: [D58239826](https://our.internmc.facebook.com/intern/diff/D58239826) Pull Request resolved: #126817 Approved by: https://github.com/eellison ghstack dependencies: #128037, #128086
TharinduRusira
pushed a commit
to TharinduRusira/pytorch
that referenced
this pull request
Jun 14, 2024
…ch#128037) Summary: Observed on an internal workload: the helper thread started and attempted to access member variables before they were initialized. Differential Revision: [D58239827](https://our.internmc.facebook.com/intern/diff/D58239827) Pull Request resolved: pytorch#128037 Approved by: https://github.com/Skylion007, https://github.com/eellison
TharinduRusira
pushed a commit
to TharinduRusira/pytorch
that referenced
this pull request
Jun 14, 2024
… work to the pool (pytorch#128086) Summary: I got reports of intermittent failures in CI and the logs show errors like this: ``` CRITICAL:concurrent.futures:Future 139789013754560 in unexpected state: FINISHED ``` I can't repro locally, but seems clear that we should initialize the future _before_ sending work to the subprocess pool since it could finish before we call set_running_or_notify_cancel() Differential Revision: [D58239829](https://our.internmc.facebook.com/intern/diff/D58239829) Pull Request resolved: pytorch#128086 Approved by: https://github.com/jansel ghstack dependencies: pytorch#128037
TharinduRusira
pushed a commit
to TharinduRusira/pytorch
that referenced
this pull request
Jun 14, 2024
…ytorch#126817) Differential Revision: [D58239826](https://our.internmc.facebook.com/intern/diff/D58239826) Pull Request resolved: pytorch#126817 Approved by: https://github.com/eellison ghstack dependencies: pytorch#128037, pytorch#128086
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: Observed on an internal workload: the helper thread started and attempted to access member variables before they were initialized.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang
Differential Revision: D58239827