-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Validate that node TK_ASSIGN have field initialized #127878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127878
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d288d9c with merge base c2eeda5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but can you please add unit test to validate the failure?
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_8-cuda11_8-test / test Details for Dev Infra teamRaised by workflow job |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
8253a89 to
d288d9c
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes segmentation fault during model load via C++ API.
An
Assignstatement (TK_ASSIGNtype) have 3 fields:lhs,rhsandtype. Fieldtypeis of typeMaybe, which means it could be not presented. During model load inimport_source.cppfieldtypeis dereferenced without validation.It is similar error that have been fixed in #106041.
Fixes #127877