Skip to content

Conversation

@apach301
Copy link
Contributor

@apach301 apach301 commented Jun 4, 2024

Fixes segmentation fault during model load via C++ API.

An Assign statement (TK_ASSIGN type) have 3 fields: lhs, rhs and type. Field type is of type Maybe, which means it could be not presented. During model load in import_source.cpp field type is dereferenced without validation.

It is similar error that have been fixed in #106041.

Fixes #127877

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 4, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127878

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d288d9c with merge base c2eeda5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Jun 4, 2024
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you please add unit test to validate the failure?

@malfet malfet added the topic: bug fixes topic category label Jun 4, 2024
@malfet
Copy link
Contributor

malfet commented Jun 4, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 4, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_8-cuda11_8-test / test

Details for Dev Infra team Raised by workflow job

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2024

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Aug 3, 2024
@apach301
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased validate-tree_view-object onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout validate-tree_view-object && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the validate-tree_view-object branch from 8253a89 to d288d9c Compare August 14, 2024 11:01
@apach301
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: jit release notes category Stale topic: bug fixes topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Segmentation fault in import_source.cpp during loading model via C++ API

4 participants