Skip to content

Reapply "distributed debug handlers (#126601)" #127805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
d4l3k wants to merge 1 commit into from
Closed

Reapply "distributed debug handlers (#126601)" #127805

d4l3k wants to merge 1 commit into from

Conversation

@d4l3k
Copy link
Member

@d4l3k d4l3k commented Jun 3, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 3, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127805

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f78cf1e with merge base a4064da (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (torchelastic) labels Jun 3, 2024
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 3, 2024

@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@d4l3k d4l3k force-pushed the d4l3k/reapply_debug branch from 5473cb3 to f78cf1e Compare June 3, 2024 21:11
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 4, 2024

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 4, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@d4l3k d4l3k deleted the d4l3k/reapply_debug branch June 5, 2024 17:02
bigfootjon pushed a commit that referenced this pull request Jun 5, 2024
@d4l3k @bigfootjon
Reapply "distributed debug handlers (#126601)" (#127805)
86d53d5 
This reverts commit 7646825.

Pull Request resolved: #127805
Approved by: https://github.com/PaliC

(cherry picked from commit 597922b)
@malfet malfet mentioned this pull request Aug 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@PaliC PaliC PaliC approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (torchelastic)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@d4l3k @facebook-github-bot @pytorchmergebot @PaliC