Inductor respects strides for custom ops by default #126986
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the default was that Inductor did not respect strides for all (builtin and custom) ops unless the op has a "needs_fixed_stride_order" tag on it. This PR changes it so that: - inductor doesn't respect strides for builtin ops. To change the behavior, one can add the "needs_fixed_stride_order" tag - inductor does respect strides for custom ops. To change the behavior, one can add the "does_not_need_fixed_stride_order" tag Test Plan: - new tests [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126986
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 3e412f7 with merge base f0366de ( UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zou3519
added a commit
that referenced
this pull request
May 23, 2024
Previously, the default was that Inductor did not respect strides for all (builtin and custom) ops unless the op has a "needs_fixed_stride_order" tag on it. This PR changes it so that: - inductor doesn't respect strides for builtin ops. To change the behavior, one can add the "needs_fixed_stride_order" tag - inductor does respect strides for custom ops. To change the behavior, one can add the "does_not_need_fixed_stride_order" tag Test Plan: - new tests ghstack-source-id: cf25fd6 Pull Request resolved: #126986
ezyang
approved these changes
May 23, 2024
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
The negation is kinda goofy but ok
albanD
approved these changes
May 23, 2024
Collaborator
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
A bit sad that the changing default forces us to have 2 flags yeah.
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
titaiwangms
pushed a commit
to titaiwangms/pytorch
that referenced
this pull request
May 28, 2024
Previously, the default was that Inductor did not respect strides for all (builtin and custom) ops unless the op has a "needs_fixed_stride_order" tag on it. This PR changes it so that: - inductor doesn't respect strides for builtin ops. To change the behavior, one can add the "needs_fixed_stride_order" tag - inductor does respect strides for custom ops. To change the behavior, one can add the "does_not_need_fixed_stride_order" tag Test Plan: - new tests Pull Request resolved: pytorch#126986 Approved by: https://github.com/ezyang, https://github.com/albanD
zou3519
added a commit
that referenced
this pull request
Jun 4, 2024
This reverts commit dd64ca2. There's a silent incorrectness bug with needs_fixed_stride_order=True and mutable custom ops, so it's better to flip the default back to avoid silent incorrectness. [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 4, 2024
#127923) This reverts commit dd64ca2. There's a silent incorrectness bug with needs_fixed_stride_order=True and mutable custom ops, so it's better to flip the default back to avoid silent incorrectness. Pull Request resolved: #127923 Approved by: https://github.com/williamwen42
zou3519
added a commit
that referenced
this pull request
Sep 5, 2024
By default, Inductor is allowed to manipulate the layout (strides+storage offset) of input tensors to custom operators. We want to change it so that the default is that Inductor should respect the stride order of input tensors to custom operators. This PR adds a config to toggle the behavior, in the next PR up we'll change the default. We also make the following changes: - We add a new operator Tag (flexible_layout), which means that inductor is allowed to manipulate the layout. When we flip the default, users can specify they want the old behavior by using this tag. This is a reland of #126986, which was previously reverted due to silent incorrectness. We've since fixed the silent incorrectness (#133639) Test Plan: - new test [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 6, 2024
By default, Inductor is allowed to manipulate the layout (strides+storage offset) of input tensors to custom operators. We want to change it so that the default is that Inductor should respect the stride order of input tensors to custom operators. This PR adds a config to toggle the behavior, in the next PR up we'll change the default. We also make the following changes: - We add a new operator Tag (flexible_layout), which means that inductor is allowed to manipulate the layout. When we flip the default, users can specify they want the old behavior by using this tag. This is a reland of #126986, which was previously reverted due to silent incorrectness. We've since fixed the silent incorrectness (#133639) Test Plan: - new test Pull Request resolved: #135238 Approved by: https://github.com/albanD
enter-ctrl9
pushed a commit
to enter-ctrl9/pytorch11
that referenced
this pull request
Sep 15, 2024
By default, Inductor is allowed to manipulate the layout (strides+storage offset) of input tensors to custom operators. We want to change it so that the default is that Inductor should respect the stride order of input tensors to custom operators. This PR adds a config to toggle the behavior, in the next PR up we'll change the default. We also make the following changes: - We add a new operator Tag (flexible_layout), which means that inductor is allowed to manipulate the layout. When we flip the default, users can specify they want the old behavior by using this tag. This is a reland of pytorch/pytorch#126986, which was previously reverted due to silent incorrectness. We've since fixed the silent incorrectness (pytorch/pytorch#133639) Test Plan: - new test ghstack-source-id: ce6c52d Pull Request resolved: pytorch/pytorch#135238
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
By default, Inductor is allowed to manipulate the layout (strides+storage offset) of input tensors to custom operators. We want to change it so that the default is that Inductor should respect the stride order of input tensors to custom operators. This PR adds a config to toggle the behavior, in the next PR up we'll change the default. We also make the following changes: - We add a new operator Tag (flexible_layout), which means that inductor is allowed to manipulate the layout. When we flip the default, users can specify they want the old behavior by using this tag. This is a reland of pytorch#126986, which was previously reverted due to silent incorrectness. We've since fixed the silent incorrectness (pytorch#133639) Test Plan: - new test Pull Request resolved: pytorch#135238 Approved by: https://github.com/albanD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Previously, the default was that Inductor did not respect strides for
all (builtin and custom) ops unless the op has a
"needs_fixed_stride_order" tag on it. This PR changes it so that:
behavior, one can add the "needs_fixed_stride_order" tag
one can add the "does_not_need_fixed_stride_order" tag
Test Plan:
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang