[BE] wrap deprecated function/class with `typing_extensions.deprecated` #126898

XuehaiPan · 2024-05-22T19:48:36Z

Use typing_extensions.deprecated for deprecation annotation if possible. Otherwise, add category=FutureWarning to warnings.warn("message") if the category is missing.

Note that only warnings that their messages contain [Dd]eprecat(ed|ion) are updated in this PR.

UPDATE: Use FutureWarning instead of DeprecationWarning.

Resolves #126888

[BE] wrap deprecated function/class with typing_extensions.deprecated for better IDE integration #126888

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @ezyang @malfet @xuzhao9 @gramster @mcarilli @ptrblck @leslie-fang-intel @voznesenskym @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @LucasLLC

pytorch-bot · 2024-05-22T19:48:39Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126898

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 109 New Failures, 32 Unrelated Failures

As of commit 2653d0c with merge base 114c752 ():

NEW FAILURES - The following jobs have failed:

inductor / cuda12.1-py3.10-gcc9-sm80 / test (inductor_torchbench_smoketest_perf, 1, 1, linux.gcp.a100) (gh)
inductor / cuda12.1-py3.10-gcc9-sm86 / test (aot_inductor_huggingface, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.1-py3.10-gcc9-sm86 / test (aot_inductor_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.1-py3.10-gcc9-sm86 / test (aot_inductor_timm, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.1-py3.10-gcc9-sm86 / test (aot_inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.1-py3.10-gcc9-sm86 / test (aot_inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.1-py3.10-gcc9-sm86 / test (dynamic_inductor_huggingface, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.1-py3.10-gcc9-sm86 / test (dynamic_inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.1-py3.10-gcc9-sm86 / test (dynamic_inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_cpp_wrapper_abi_compatible, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_distributed, 1, 1, linux.g5.12xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_huggingface, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.4-py3.10-gcc9-sm80 / test (inductor_torchbench_smoketest_perf, 1, 1, linux.gcp.a100) (gh)
inductor / cuda12.4-py3.10-gcc9-sm86 / test (aot_inductor_huggingface, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.4-py3.10-gcc9-sm86 / test (aot_inductor_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.4-py3.10-gcc9-sm86 / test (aot_inductor_timm, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.4-py3.10-gcc9-sm86 / test (aot_inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.4-py3.10-gcc9-sm86 / test (aot_inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.4-py3.10-gcc9-sm86 / test (dynamic_inductor_huggingface, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.4-py3.10-gcc9-sm86 / test (dynamic_inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.4-py3.10-gcc9-sm86 / test (dynamic_inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.4-py3.10-gcc9-sm86 / test (inductor_cpp_wrapper_abi_compatible, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.4-py3.10-gcc9-sm86 / test (inductor_distributed, 1, 1, linux.g5.12xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.4-py3.10-gcc9-sm86 / test (inductor_huggingface, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.4-py3.10-gcc9-sm86 / test (inductor_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.4-py3.10-gcc9-sm86 / test (inductor_timm, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.4-py3.10-gcc9-sm86 / test (inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.4-py3.10-gcc9-sm86 / test (inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.4-py3.10-gcc9-sm86 / test (inductor, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor / cuda12.4-py3.12-gcc9-sm86 / test (inductor, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh)
inductor / linux-jammy-cpu-py3.8-gcc11-inductor / test (cpu_inductor_torchbench, 1, 2, linux.12xlarge) (gh)
##[error]The operation was canceled.
inductor / linux-jammy-cpu-py3.8-gcc11-inductor / test (dynamic_cpu_inductor_torchbench, 1, 2, linux.12xlarge) (gh)
##[error]The operation was canceled.
inductor / linux-jammy-cpu-py3.8-gcc11-inductor / test (dynamic_cpu_inductor_torchbench, 2, 2, linux.12xlarge) (gh)
##[error]The operation was canceled.
inductor / rocm6.1-py3.8-inductor (gh)
inductor / rocm6.1-py3.8-inductor / build (gh)
##[error]The operation was canceled.
inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (aot_eager_huggingface, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (aot_eager_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (aot_eager_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (aot_eager_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (dynamic_aot_eager_huggingface, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (dynamic_aot_eager_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (dynamic_aot_eager_timm, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (dynamic_aot_eager_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (dynamic_aot_eager_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (dynamo_eager_huggingface, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (dynamo_eager_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (dynamo_eager_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (dynamo_eager_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
linux-binary-libtorch-cxx11-abi / libtorch-cpu-shared-with-deps-cxx11-abi-test / test (gh)
##[error]The operation was canceled.
linux-binary-libtorch-pre-cxx11 / libtorch-cpu-shared-with-deps-pre-cxx11-test / test (gh)
##[error]The operation was canceled.
linux-binary-manywheel / manywheel-py3_8-cuda11_8-build / build (gh)
##[error]The operation was canceled.
linux-binary-manywheel / manywheel-py3_8-cuda11_8-test (gh)
linux-binary-manywheel / manywheel-py3_8-cuda12_1-build / build (gh)
##[error]The operation was canceled.
linux-binary-manywheel / manywheel-py3_8-cuda12_1-test (gh)
linux-binary-manywheel / manywheel-py3_8-cuda12_4-build / build (gh)
##[error]The operation was canceled.
linux-binary-manywheel / manywheel-py3_8-cuda12_4-test (gh)
pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 1, 3, linux.8xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 2, 3, linux.8xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 3, 3, linux.8xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 1, 5, linux.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 2, 5, linux.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 3, 5, linux.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 4, 5, linux.4xlarge.nvidia.gpu) (gh)
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 5, 5, linux.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.4-py3.10-gcc9 / test (default, 1, 5, linux.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.4-py3.10-gcc9 / test (default, 2, 5, linux.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.4-py3.10-gcc9 / test (default, 3, 5, linux.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.4-py3.10-gcc9 / test (default, 4, 5, linux.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.4-py3.10-gcc9 / test (default, 5, 5, linux.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3_8-clang9-xla / test (xla, 1, 1, linux.12xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.11-clang10 / test (crossref, 1, 2, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.11-clang10 / test (crossref, 2, 2, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.11-clang10 / test (default, 1, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.11-clang10 / test (default, 2, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.11-clang10 / test (default, 3, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.11-clang10 / test (dynamo, 1, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.11-clang10 / test (dynamo, 2, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.11-clang10 / test (dynamo, 3, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.12-clang10 / test (dynamo, 1, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.12-clang10 / test (dynamo, 2, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.12-clang10 / test (dynamo, 3, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10 / test (crossref, 1, 2, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10 / test (crossref, 2, 2, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10 / test (default, 1, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10 / test (default, 2, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10 / test (default, 3, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10 / test (dynamo, 1, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10 / test (dynamo, 2, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10 / test (dynamo, 3, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10-onnx / test (default, 1, 2, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10-onnx / test (default, 2, 2, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-rocm6.1-py3.8 / build (gh)
##[error]The operation was canceled.
pull / linux-jammy-py3.8-gcc11 / test (default, 1, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-jammy-py3.8-gcc11 / test (default, 2, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-jammy-py3.8-gcc11 / test (default, 3, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-jammy-py3.8-gcc11 / test (distributed, 1, 2, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-jammy-py3.8-gcc11 / test (distributed, 2, 2, linux.2xlarge) (gh)
##[error]The operation was canceled.
trunk / linux-focal-cuda12.1-py3.10-gcc9 / test (nogpu_NO_AVX2, 1, 1, linux.2xlarge) (gh)
##[error]The operation was canceled.
trunk / linux-focal-cuda12.4-py3.10-gcc9 / test (jit_legacy, 1, 1, linux.4xlarge.nvidia.gpu) (gh)
trunk / linux-focal-cuda12.4-py3.10-gcc9 / test (nogpu_AVX512, 1, 1, linux.2xlarge) (gh)
##[error]The operation was canceled.
trunk / linux-focal-cuda12.4-py3.10-gcc9 / test (nogpu_NO_AVX2, 1, 1, linux.2xlarge) (gh)
##[error]The operation was canceled.
trunk / linux-focal-rocm6.1-py3.8 (gh)
trunk / linux-focal-rocm6.1-py3.8 / build (gh)
##[error]The operation was canceled.
trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable) (gh)
##[error]The operation was canceled.
trunk / macos-py3-arm64 / test (default, 3, 3, macos-m1-stable) (gh)
##[error]The operation was canceled.
trunk / pytorch-linux-focal-py3-clang9-android-ndk-r21e-build / build (default, 1, 1, linux.2xlarge) (gh)
##[error]The operation was canceled.
trunk / win-vs2019-cpu-py3 / test (default, 1, 3, windows.4xlarge.nonephemeral) (gh)
Process completed with exit code 1.

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh) (similar failure)
##[error]The operation was canceled.
inductor / cuda12.1-py3.12-gcc9-sm86 / test (inductor, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh) (similar failure)
##[error]The operation was canceled.
inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (aot_eager_timm, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (similar failure)
##[error]The operation was canceled.
inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (dynamo_eager_timm, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (similar failure)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 1, 5, linux.g5.4xlarge.nvidia.gpu) (gh) (similar failure)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 2, 5, linux.g5.4xlarge.nvidia.gpu) (gh) (similar failure)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 3, 5, linux.g5.4xlarge.nvidia.gpu) (gh) (similar failure)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 4, 5, linux.g5.4xlarge.nvidia.gpu) (gh) (similar failure)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 5, 5, linux.g5.4xlarge.nvidia.gpu) (gh) (similar failure)
##[error]The operation was canceled.
pull / linux-focal-py3.12-clang10 / test (default, 1, 3, linux.2xlarge) (gh) (similar failure)
##[error]The operation was canceled.
pull / linux-focal-py3.12-clang10 / test (default, 2, 3, linux.2xlarge) (gh) (similar failure)
##[error]The operation was canceled.
pull / linux-focal-py3.12-clang10 / test (default, 3, 3, linux.2xlarge) (gh) (similar failure)
##[error]The operation was canceled.
pull / linux-jammy-py3.10-clang15-asan / test (default, 1, 6, linux.4xlarge) (gh) (similar failure)
##[error]The operation was canceled.
pull / linux-jammy-py3.10-clang15-asan / test (default, 2, 6, linux.4xlarge) (gh) (similar failure)
##[error]The operation was canceled.
pull / linux-jammy-py3.10-clang15-asan / test (default, 3, 6, linux.4xlarge) (gh) (similar failure)
##[error]The operation was canceled.
pull / linux-jammy-py3.10-clang15-asan / test (default, 4, 6, linux.4xlarge) (gh) (similar failure)
##[error]The operation was canceled.
pull / linux-jammy-py3.10-clang15-asan / test (default, 5, 6, linux.4xlarge) (gh) (similar failure)
##[error]The operation was canceled.
pull / linux-jammy-py3.10-clang15-asan / test (default, 6, 6, linux.4xlarge) (gh) (similar failure)
##[error]The operation was canceled.
trunk / linux-focal-cuda12.1-py3.10-gcc9 / test (nogpu_AVX512, 1, 1, linux.2xlarge) (gh) (similar failure)
##[error]The operation was canceled.
trunk / win-vs2019-cpu-py3 / test (default, 2, 3, windows.4xlarge.nonephemeral) (gh) (matched win rule in flaky-rules.json)
##[error]The operation was canceled.
trunk / win-vs2019-cpu-py3 / test (default, 3, 3, windows.4xlarge.nonephemeral) (gh) (matched win rule in flaky-rules.json)
##[error]The operation was canceled.

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

inductor / cuda12.1-py3.10-gcc9-sm86 / test (dynamic_inductor_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu, unstable) (gh) (#127438)
##[error]The operation was canceled.
inductor / cuda12.1-py3.10-gcc9-sm86 / test (dynamic_inductor_timm, 2, 2, linux.g5.4xlarge.nvidia.gpu, unstable) (gh) (#127438)
##[error]The operation was canceled.
inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu, unstable) (gh) (#126884)
##[error]The operation was canceled.
inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_timm, 2, 2, linux.g5.4xlarge.nvidia.gpu, unstable) (gh) (#126884)
##[error]The operation was canceled.
inductor / cuda12.4-py3.10-gcc9-sm86 / test (dynamic_inductor_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu, unstable) (gh) (#127680)
##[error]The operation was canceled.
inductor / cuda12.4-py3.10-gcc9-sm86 / test (dynamic_inductor_timm, 2, 2, linux.g5.4xlarge.nvidia.gpu, unstable) (gh) (#127680)
##[error]The operation was canceled.
pull / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 1, 5, linux.g5.4xlarge.nvidia.gpu, unstable) (gh) ()
##[error]The operation was canceled.
pull / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 2, 5, linux.g5.4xlarge.nvidia.gpu, unstable) (gh) ()
##[error]The operation was canceled.
pull / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 3, 5, linux.g5.4xlarge.nvidia.gpu, unstable) (gh) ()
##[error]The operation was canceled.
pull / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 4, 5, linux.g5.4xlarge.nvidia.gpu, unstable) (gh) ()
##[error]The operation was canceled.
pull / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 5, 5, linux.g5.4xlarge.nvidia.gpu, unstable) (gh) ()
##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

torch/ao/quantization/fx/quantize_handler.py

albanD

I don't think we should use DeprecationWarning in general.
These warnings types are hidden by default and we explicitly want users to see these warnings so they update their code.

So we would need to update the calls using deprecated() to use UserWarning and continue to use that for all other warnings.

torch/_dynamo/external_utils.py

XuehaiPan · 2024-05-24T12:14:04Z

I don't think we should use DeprecationWarning in general. These warnings types are hidden by default and we explicitly want users to see these warnings so they update their code.

After referring to the Python documentation, I noticed that DeprecationWarnings is ignored by default (except DeprecationWarnings warned in __main__).

exception DeprecationWarning
Base class for warnings about deprecated features when those warnings are intended for other Python developers.

Ignored by the default warning filters, except in the main module (PEP 565). Enabling the Python Development Mode shows this warning.

I update DeprecationWarnings to FutureWarnings in this PR.

Warning Categories

Changed in version 3.7: Previously DeprecationWarning and FutureWarning were distinguished based on whether a feature was being removed entirely or changing its behaviour. They are now distinguished based on their intended audience and the way they’re handled by the default warnings filters.

So we would need to update the calls using deprecated() to use UserWarning and continue to use that for all other warnings.

Based on the documentation, I'd prefer FutureWarning instead of UserWarning. Note that only warnings that their messages contain [Dd]eprecat(ed|ion) are updated in this PR.

exception UserWarning
Base class for warnings generated by user code.

exception FutureWarning
Base class for warnings about deprecated features when those warnings are intended for end users of applications that are written in Python.

XuehaiPan · 2024-06-01T18:08:19Z

This PR is split into two:

…d` (#127689) Use `typing_extensions.deprecated` for deprecation annotation if possible. Otherwise, add `category=FutureWarning` to `warnings.warn("message")` if the category is missing. Note that only warnings that their messages contain `[Dd]eprecat(ed|ion)` are updated in this PR. Resolves #126888 - #126888 This PR is split from PR #126898. - #126898 ------ Pull Request resolved: #127689 Approved by: https://github.com/Skylion007

…d` (#126898) Use `typing_extensions.deprecated` for deprecation annotation if possible. Otherwise, add `category=FutureWarning` to `warnings.warn("message")` if the category is missing. Note that only warnings that their messages contain `[Dd]eprecat(ed|ion)` are updated in this PR. UPDATE: Use `FutureWarning` instead of `DeprecationWarning`. Resolves #126888 - #126888 Pull Request resolved: #126898 Approved by: https://github.com/albanD (cherry picked from commit 749a132)

…eprecated` (#126898)" This reverts commit 749a132. Reverted #126898 on behalf of https://github.com/fbgheith due to switching typing-extensions=4.3.0 to 4.9.0 causes internal failure ([comment](#126898 (comment))) (cherry picked from commit 033e733)

…d` (#127689) Use `typing_extensions.deprecated` for deprecation annotation if possible. Otherwise, add `category=FutureWarning` to `warnings.warn("message")` if the category is missing. Note that only warnings that their messages contain `[Dd]eprecat(ed|ion)` are updated in this PR. Resolves #126888 - #126888 This PR is split from PR #126898. - #126898 ------ Pull Request resolved: #127689 Approved by: https://github.com/Skylion007 (cherry picked from commit 67ef268)

…ytorch#127433)" This reverts commit 6e0eeec. Reverted pytorch#127433 on behalf of https://github.com/fbgheith due to depends on pytorch#126898 which is failing internally and needs to be reverted ([comment](pytorch#127433 (comment)))

…eprecated` (pytorch#126898)" This reverts commit 749a132. Reverted pytorch#126898 on behalf of https://github.com/fbgheith due to switching typing-extensions=4.3.0 to 4.9.0 causes internal failure ([comment](pytorch#126898 (comment)))

…d` (pytorch#127689) Use `typing_extensions.deprecated` for deprecation annotation if possible. Otherwise, add `category=FutureWarning` to `warnings.warn("message")` if the category is missing. Note that only warnings that their messages contain `[Dd]eprecat(ed|ion)` are updated in this PR. Resolves pytorch#126888 - pytorch#126888 This PR is split from PR pytorch#126898. - pytorch#126898 ------ Pull Request resolved: pytorch#127689 Approved by: https://github.com/Skylion007

…tils.is_compiling()` (#127690) This PR is split from PR #126898. - #126898 ------ Pull Request resolved: #127690 Approved by: https://github.com/Skylion007

…ternal_utils.is_compiling()` (#127690)" This reverts commit 348b181. Reverted #127690 on behalf of https://github.com/clee2000 due to sorry I think #126898 (comment) is still relevant, I will reach out to them to see what needs to be done in internal to get this remerged ([comment](#127690 (comment)))

…tils.is_compiling()` (pytorch#127690) This PR is split from PR pytorch#126898. - pytorch#126898 ------ Pull Request resolved: pytorch#127690 Approved by: https://github.com/Skylion007

…ternal_utils.is_compiling()` (pytorch#127690)" This reverts commit 348b181. Reverted pytorch#127690 on behalf of https://github.com/clee2000 due to sorry I think pytorch#126898 (comment) is still relevant, I will reach out to them to see what needs to be done in internal to get this remerged ([comment](pytorch#127690 (comment)))

…tils.is_compiling()` (#127690) This PR is split from PR #126898. - #126898 ------ Pull Request resolved: #127690 Approved by: https://github.com/Skylion007, https://github.com/malfet

…tils.is_compiling()` (pytorch#127690) This PR is split from PR pytorch#126898. - pytorch#126898 ------ Pull Request resolved: pytorch#127690 Approved by: https://github.com/Skylion007, https://github.com/malfet

This PR is split from PR #126898. - #126898 ------ Pull Request resolved: #127690 Approved by: https://github.com/Skylion007, https://github.com/malfet

This PR is split from PR pytorch#126898. - pytorch#126898 ------ Pull Request resolved: pytorch#127690 Approved by: https://github.com/Skylion007, https://github.com/malfet

XuehaiPan added module: typing Related to mypy type annotations better-engineering Relatively self-contained tasks for better engineering contributors module: deprecation topic: deprecation topic category labels May 22, 2024

XuehaiPan requested review from aaronenyeshi, albanD, andrewkho, eqy, gokulavasan, jbschlosser, mikaylagawarecki and soulitzer as code owners May 22, 2024 19:48

XuehaiPan force-pushed the warnings-deprecated branch from 0d8e8d4 to 447ffdc Compare May 22, 2024 19:52

mikaylagawarecki removed their request for review May 22, 2024 20:01

pytorchbot added the open source label May 22, 2024

pytorch-bot bot added the module: inductor label May 23, 2024

ezyang reviewed May 23, 2024

View reviewed changes

torch/ao/quantization/fx/quantize_handler.py Show resolved Hide resolved

albanD requested changes May 23, 2024

View reviewed changes

torch/_dynamo/external_utils.py Outdated Show resolved Hide resolved

bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 23, 2024

XuehaiPan force-pushed the warnings-deprecated branch from 27c7de3 to 8fab07a Compare May 24, 2024 11:17

XuehaiPan force-pushed the warnings-deprecated branch from e88aa54 to 584cd49 Compare May 24, 2024 12:22

XuehaiPan closed this Jun 1, 2024

XuehaiPan deleted the warnings-deprecated branch June 14, 2024 19:29

frances720 mentioned this pull request Nov 6, 2024

Deprecate torch._utils.is_compiling() and `torch._dynamo.external_u… Promptless/pytorch-test#4

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[BE] wrap deprecated function/class with `typing_extensions.deprecated` #126898

[BE] wrap deprecated function/class with `typing_extensions.deprecated` #126898

Uh oh!

XuehaiPan commented May 22, 2024 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented May 22, 2024 •

edited

Loading

Uh oh!

Uh oh!

albanD left a comment

Uh oh!

Uh oh!

XuehaiPan commented May 24, 2024

Warning Categories

Uh oh!

XuehaiPan commented Jun 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

[BE] wrap deprecated function/class with typing_extensions.deprecated #126898

[BE] wrap deprecated function/class with typing_extensions.deprecated #126898

Uh oh!

Conversation

XuehaiPan commented May 22, 2024 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented May 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126898

❌ 109 New Failures, 32 Unrelated Failures

Uh oh!

Uh oh!

albanD left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

XuehaiPan commented May 24, 2024

Warning Categories

Uh oh!

XuehaiPan commented Jun 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

[BE] wrap deprecated function/class with `typing_extensions.deprecated` #126898

[BE] wrap deprecated function/class with `typing_extensions.deprecated` #126898

XuehaiPan commented May 22, 2024 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented May 22, 2024 •

edited

Loading