Support generic stream/event on XPU backend #125751
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125751
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 5b51a4f with merge base affd7a9 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
guangyey
added
intel
guangyey
commented
May 8, 2024
|
|
||
| @unittest.skipIf( | ||
| IS_ARM64 or not IS_LINUX or TEST_CUDA or TEST_PRIVATEUSE1 or TEST_ROCM, | ||
| IS_ARM64 or not IS_LINUX or TEST_CUDA or TEST_PRIVATEUSE1 or TEST_ROCM or TEST_XPU, |
Collaborator
Author
There was a problem hiding this comment.
It is mutually exclusive to xpu.
Collaborator
There was a problem hiding this comment.
cc @egienvalue with me want to add a TEST_MTIA to common_utils above to simplify this kind of statement!
Contributor
There was a problem hiding this comment.
I see. Thanks for the suggestion. I will do that.
Collaborator
Author
|
@albanD, if this PR is fine, I will continue to support CUDA following this. |
[ghstack-poisoned]
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 gujinghui EikanWang fengyuan14 [ghstack-poisoned]
# Motivation According to [#123611](#123611), we support generic stream/event on XPU backend. # Additional Context new method/attribute on `torch.Event` - torch.Event.event_id - torch.Event.elapsed_time - torch.Event.synchronize new method on `c10::Event` - c10.Event.event_id - c10.Event.elapsed_time - c10.Event.synchronize cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 gujinghui EikanWang fengyuan14 [ghstack-poisoned]
# Motivation According to [#123611](#123611), we support generic stream/event on XPU backend. # Additional Context new method/attribute on `torch.Event` - torch.Event.event_id - torch.Event.elapsed_time - torch.Event.synchronize new method on `c10::Event` - c10.Event.event_id - c10.Event.elapsed_time - c10.Event.synchronize cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 gujinghui EikanWang fengyuan14 [ghstack-poisoned]
# Motivation According to [#123611](#123611), we support generic stream/event on XPU backend. # Additional Context new method/attribute on `torch.Event` - torch.Event.event_id - torch.Event.elapsed_time - torch.Event.synchronize new method on `c10::Event` - c10.Event.event_id - c10.Event.elapsed_time - c10.Event.synchronize cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 gujinghui EikanWang fengyuan14 [ghstack-poisoned]
# Motivation According to [#123611](#123611), we support generic stream/event on XPU backend. # Additional Context new method/attribute on `torch.Event` - torch.Event.event_id - torch.Event.elapsed_time - torch.Event.synchronize new method on `c10::Event` - c10.Event.event_id - c10.Event.elapsed_time - c10.Event.synchronize cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 gujinghui EikanWang fengyuan14 [ghstack-poisoned]
# Motivation According to [#123611](#123611), we support generic stream/event on XPU backend. # Additional Context new method/attribute on `torch.Event` - torch.Event.event_id - torch.Event.elapsed_time - torch.Event.synchronize new method on `c10::Event` - c10.Event.event_id - c10.Event.elapsed_time - c10.Event.synchronize cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 gujinghui EikanWang fengyuan14 [ghstack-poisoned]
# Motivation According to [#123611](#123611), we support generic stream/event on XPU backend. # Additional Context new method/attribute on `torch.Event` - torch.Event.event_id - torch.Event.elapsed_time - torch.Event.synchronize new method on `c10::Event` - c10.Event.event_id - c10.Event.elapsed_time - c10.Event.synchronize cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 gujinghui EikanWang fengyuan14 [ghstack-poisoned]
# Motivation According to [#123611](#123611), we support generic stream/event on XPU backend. # Additional Context new method/attribute on `torch.Event` - torch.Event.event_id - torch.Event.elapsed_time - torch.Event.synchronize new method on `c10::Event` - c10.Event.event_id - c10.Event.elapsed_time - c10.Event.synchronize cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 gujinghui EikanWang fengyuan14 [ghstack-poisoned]
# Motivation According to [#123611](#123611), we support generic stream/event on XPU backend. # Additional Context new method/attribute on `torch.Event` - torch.Event.event_id - torch.Event.elapsed_time - torch.Event.synchronize new method on `c10::Event` - c10.Event.event_id - c10.Event.elapsed_time - c10.Event.synchronize cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 gujinghui EikanWang fengyuan14 [ghstack-poisoned]
jgong5
approved these changes
May 9, 2024
albanD
approved these changes
May 9, 2024
|
|
||
| @unittest.skipIf( | ||
| IS_ARM64 or not IS_LINUX or TEST_CUDA or TEST_PRIVATEUSE1 or TEST_ROCM, | ||
| IS_ARM64 or not IS_LINUX or TEST_CUDA or TEST_PRIVATEUSE1 or TEST_ROCM or TEST_XPU, |
Collaborator
There was a problem hiding this comment.
cc @egienvalue with me want to add a TEST_MTIA to common_utils above to simplify this kind of statement!
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Author
Thanks for your approval~ |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Motivation
According to #123611, we support generic stream/event on XPU backend.
Additional Context
new method/attribute on
torch.Eventfor xpunew method on
c10::Eventon xpu backendcc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @gujinghui @EikanWang @fengyuan14