CI: Extending unit test coverage for aarch64 linux #125255
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125255
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fb819c4 with merge base 5f4c6d9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cpuhrsch
added
the
triaged
atalman
approved these changes
Apr 30, 2024
snadampal
force-pushed
the
aarch64_ci_unittests
branch
from
92ffee2 to
fb819c4
Compare
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorch-bot bot
pushed a commit
that referenced
this pull request
May 3, 2024
Adding core, dynamo and inductor unit tests for aarch64 linux CI runs. Pull Request resolved: #125255 Approved by: https://github.com/malfet, https://github.com/atalman
malfet
reviewed
Sep 17, 2024
Comment on lines
+23
to
+26
| { config: "default", shard: 1, num_shards: 4, runner: "linux.arm64.2xlarge" }, | ||
| { config: "default", shard: 2, num_shards: 4, runner: "linux.arm64.2xlarge" }, | ||
| { config: "default", shard: 3, num_shards: 4, runner: "linux.arm64.2xlarge" }, | ||
| { config: "default", shard: 4, num_shards: 4, runner: "linux.arm64.2xlarge" }, |
Contributor
There was a problem hiding this comment.
🤦 Note to self: be a more thorough code reviewer... This just runs the same tests 1 times over...
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 18, 2024
) Non-functional sharding was introduced in #125255 but each shard in that case were running the same tests... Pull Request resolved: #136208 Approved by: https://github.com/seemethere, https://github.com/ZainRizvi, https://github.com/atalman
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
…rch#136208) Non-functional sharding was introduced in pytorch#125255 but each shard in that case were running the same tests... Pull Request resolved: pytorch#136208 Approved by: https://github.com/seemethere, https://github.com/ZainRizvi, https://github.com/atalman
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding core, dynamo and inductor unit tests for aarch64 linux CI runs.