Skip to content

forward fix preferred blas backend and windows CI #125080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeffdaily wants to merge 1 commit into from
Closed

forward fix preferred blas backend and windows CI #125080

jeffdaily wants to merge 1 commit into from

Conversation

@jeffdaily
Copy link
Collaborator

@jeffdaily jeffdaily commented Apr 26, 2024

PR #122106 broke windows tests. The feature should have been disabled for Windows but was not disabled correctly.

@jeffdaily
forward fix preferred blas backend and windows CI
ad774b4 
PR pytorch#122106 broke windows tests. The feature should have been disabled
for Windows but was not disabled correctly.
@jeffdaily jeffdaily requested a review from clee2000 April 26, 2024 22:30
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 26, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125080

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unrelated Failures

As of commit ad774b4 with merge base 83e7b9d (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jeffdaily
Copy link
Collaborator Author

jeffdaily commented Apr 26, 2024

@clee2000 please add any labels so we can confirm that this fixes Windows tests.

@clee2000 clee2000 added the ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR label Apr 26, 2024
@jeffdaily
Copy link
Collaborator Author

jeffdaily commented Apr 27, 2024

@clee2000 I don't see how the failing unit tests have anything to do with this PR's changes. I hope this forward-fixes as requested.

clee2000
clee2000 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@clee2000 clee2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non windows failures are flaky, the windows failure can also be seen on trunk

@jeffdaily
Copy link
Collaborator Author

jeffdaily commented Apr 29, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 29, 2024
@jeffdaily jeffdaily added the topic: not user facing topic category label Apr 29, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Apr 29, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Apr 29, 2024

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@clee2000
Copy link
Contributor

clee2000 commented Apr 30, 2024

@pytorchbot merge -f "failures unrelated"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Apr 30, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@clee2000 clee2000 mentioned this pull request Apr 30, 2024
Closed
pytorch-bot bot pushed a commit that referenced this pull request May 3, 2024
@jeffdaily
forward fix preferred blas backend and windows CI (#125080)
001ed77 
PR #122106 broke windows tests. The feature should have been disabled for Windows but was not disabled correctly.
Pull Request resolved: #125080
Approved by: https://github.com/clee2000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clee2000 clee2000 clee2000 approved these changes

Assignees

No one assigned

Labels

ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeffdaily @pytorchmergebot @clee2000 @pytorchbot