Skip to content

Remove caffe2 image and video #125045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cyyever wants to merge 1 commit into from
Closed

Remove caffe2 image and video #125045

cyyever wants to merge 1 commit into from

Conversation

@cyyever
Copy link
Collaborator

@cyyever cyyever commented Apr 26, 2024 •
edited
Loading

This PR tries to decompose #122527 into a smaller one. Caffe2 image and video folders are removed along with the related CMake code.
To be noted, this was inspired and is co-dev with @r-barnes.

cc @albanD

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 26, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125045

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 886dbcc with merge base 5585138 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever requested a review from malfet April 26, 2024 16:29
@cyyever
Copy link
Collaborator Author

cyyever commented Apr 27, 2024

@r-barnes Do you mind if I merge this first?

@cyyever
Copy link
Collaborator Author

cyyever commented Apr 27, 2024

@pytorchmergebot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 27, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Apr 27, 2024

Merge failed

Reason: Approvers from one of the following sets are needed:

  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@cyyever cyyever requested a review from ezyang April 29, 2024 12:27
@ezyang
Copy link
Contributor

ezyang commented Apr 29, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Apr 29, 2024

Merge failed

Reason: Approvers from one of the following sets are needed:

  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@cyyever
Copy link
Collaborator Author

cyyever commented Apr 29, 2024

@ezyang Need your approval before merge.

@ezyang
Copy link
Contributor

ezyang commented Apr 29, 2024

we're discussing with @r-barnes what the best way to coordinate this with internal diff train is right now

@r-barnes
Copy link
Contributor

r-barnes commented Apr 30, 2024 •
edited
Loading

We're going to be good to merge this. I'll do so in the morning. Thanks for your help, @cyyever !

@cyyever
Copy link
Collaborator Author

cyyever commented Apr 30, 2024

@r-barnes When you are ready, help issue the merge command.

@r-barnes
Copy link
Contributor

r-barnes commented Apr 30, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Apr 30, 2024

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@r-barnes r-barnes added release notes: cpp release notes category topic: bc breaking topic category labels Apr 30, 2024
@r-barnes
Copy link
Contributor

r-barnes commented Apr 30, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Apr 30, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@r-barnes
Copy link
Contributor

r-barnes commented Apr 30, 2024

Thanks, @cyyever !

@cyyever cyyever deleted the caffe2_video branch April 30, 2024 23:58
@cyyever cyyever restored the caffe2_video branch April 30, 2024 23:59
petrex pushed a commit to petrex/pytorch that referenced this pull request May 3, 2024
@cyyever
Remove caffe2 image and video (pytorch#125045)
a591b7f 
This PR tries to decompose pytorch#122527 into a smaller one. Caffe2 image and video folders are removed along with the related CMake code.
To be noted, this was inspired and is co-dev with @r-barnes.

Pull Request resolved: pytorch#125045
Approved by: https://github.com/eqy, https://github.com/albanD
@kit1980
Copy link
Contributor

kit1980 commented May 3, 2024

@cyyever @r-barnes In future please try to have all changes outside of caffe2 in separate PR, like CMakeLists.txt changes.

Because this PR can not be imported to fbcode, now all changes outside of caffe2 needs to be applied manually.

@cyyever
Copy link
Collaborator Author

cyyever commented May 4, 2024

@kit1980 I see.

@cyyever cyyever deleted the caffe2_video branch May 5, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eqy eqy eqy approved these changes

@albanD albanD albanD approved these changes

@malfet malfet Awaiting requested review from malfet

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: bazel open source release notes: cpp release notes category skip-pr-sanity-checks topic: bc breaking topic category topic: build topic: deprecation topic category topic: improvements topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@cyyever @pytorchmergebot @ezyang @r-barnes @kit1980 @eqy @albanD @pytorchbot