Skip to content

[ROCm][CI] fix 5.7 nightly wheel build #124797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeffdaily wants to merge 1 commit into from
Closed

[ROCm][CI] fix 5.7 nightly wheel build #124797

jeffdaily wants to merge 1 commit into from

Conversation

@jeffdaily
Copy link
Collaborator

@jeffdaily jeffdaily commented Apr 23, 2024 •
edited by pytorch-bot bot
Loading

@jeffdaily jeffdaily requested review from atalman and malfet April 23, 2024 23:14
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 23, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124797

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit c34d06a with merge base 4ceb44c (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/rocm Trigger "default" config CI on ROCm module: rocm AMD GPU support for Pytorch labels Apr 23, 2024
@jeffdaily jeffdaily added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 24, 2024
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 24, 2024
@jeffdaily
Copy link
Collaborator Author

jeffdaily commented Apr 24, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Apr 24, 2024

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@jeffdaily jeffdaily added the topic: not user facing topic category label Apr 24, 2024
@jeffdaily
Copy link
Collaborator Author

jeffdaily commented Apr 24, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Apr 24, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

alat-rights pushed a commit to alat-rights/pytorch that referenced this pull request Apr 26, 2024
@jeffdaily
[ROCm][CI] fix 5.7 nightly wheel build (pytorch#124797)
a3ff96b 
Fixes broken ROCm 5.7 build caused by pytorch#122106.

Pull Request resolved: pytorch#124797
Approved by: https://github.com/atalman
pytorch-bot bot pushed a commit that referenced this pull request May 3, 2024
@jeffdaily
[ROCm][CI] fix 5.7 nightly wheel build (#124797)
bcf4db6 
Fixes broken ROCm 5.7 build caused by #122106.

Pull Request resolved: #124797
Approved by: https://github.com/atalman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

@malfet malfet Awaiting requested review from malfet

Assignees

No one assigned

Labels

ciflow/rocm Trigger "default" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request Merged module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jeffdaily @pytorchmergebot @atalman @soulitzer @pytorchbot