[noland] try C10_EXPORT on gcc #12423
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 6, 2018
Closed
Yangqing
reviewed
Oct 7, 2018
aten/src/ATen/core/typeid.h
Outdated
| #define CAFFE_KNOWN_TYPE(T) \ | ||
| template <> \ | ||
| EXPORT_IF_NOT_GCC TypeIdentifier TypeIdentifier::Get<T>() { \ | ||
| CAFFE2_API TypeIdentifier TypeIdentifier::Get<T>() { \ |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
smessmer
force-pushed
the
export-D10229684
branch
2 times, most recently
from
f2109a6 to
06f5f06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #12412 [noland] try if global variable on msvc works with CAFFE2_API 💛
:black_circle: #12423 [noland] try C10_EXPORT on gcc 💛
Differential Revision: D10232154