I can't do a proper review of the yml, because it's already checked in, but we're due for one.

This seems like an outlandishly large timeout for a git merge

Use git rev-parse origin/master instead. Much shorter, and it's appropriate use of Git plumbing. https://git-scm.com/book/en/v2/Git-Internals-Plumbing-and-Porcelain

pytorch/.circleci/config.yml

Line 27 in 63b8ac1

git checkout -f ${GIT_COMMIT}

Shouldn't you already be checked out at this point?

pytorch/.circleci/config.yml

Line 28 in 63b8ac1

git reset --hard ${GIT_COMMIT}

And if you just checked out that commit, why do you need to do a hard reset?

pytorch/.circleci/config.yml

Line 34 in 63b8ac1

working_directory: /var/lib/jenkins/workspace

LOL. I guess it will be forever immortalized in our Docker images haha.

pytorch/.circleci/config.yml

Line 41 in 63b8ac1

no_output_timeout: "10h"

no_output_timeout here is appropriate, but it still seems ludicrously high. There are a bunch more of these which I will no longer comment on.

I'd quite like to get rid of this ASAP.

You're pushing Docker now. Do you need this?

Hmm?

The copypasta BUUURNS

WTF! (No action needed)

Doesn't this mean DockerVersion updates are broken now?

So, what's the deployment plan? How long will we run them side-by-side before switching Jenkins off?

@ezyang Remaining issues are tracked in #12396.

For deployment, I am thinking of making an internal post on Monday, and then make a clean switch from Jenkins to CircleCI on the same day (probably at a set time such as 4pm PT).

@ezyang Yes DockerVersion will be broken and in the short term we will need to open a PR to update the Docker image version. In the long term we might want to make the following change:

Right now the Docker image push flow is "create a new image" -> "test against master" -> "push to ECR" -> "update DockerVersion.groovy". But once all Linux jobs are removed from Jenkins, we might want to do "create a new image" -> "push to ECR" -> "open PR to test against master" -> "merge new image version number into master config.yml". For the ECR clean up job in Jenkins, we will let it check the newest version number from PyTorch repo and do the clean up accordingly.