Replace _StreamBase/_EventBase with torch.Stream/Event #123707
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we have device generic torch.Event/Stream now, it is safe to replace _StreamBase/_Eventbase with torch.Stream/Event. - torch.cuda.Stream/torch.xpu/Stream won't need to inherit from _StreamBase - Alias is created between _StreamBase/_EventBase and torch.Stream/Event, because the dynamo is using them to trace stream and event. Differential Revision: [D55941611](https://our.internmc.facebook.com/intern/diff/D55941611/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/123707
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 1f9a839 with merge base 3a7351b ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55941611 |
This was referenced Apr 10, 2024
egienvalue
added a commit
that referenced
this pull request
Apr 10, 2024
Since we have device generic torch.Event/Stream now, it is safe to replace _StreamBase/_Eventbase with torch.Stream/Event. - torch.cuda.Stream/torch.xpu/Stream won't need to inherit from _StreamBase - Alias is created between _StreamBase/_EventBase and torch.Stream/Event, because the dynamo is using them to trace stream and event. Differential Revision: [D55941611](https://our.internmc.facebook.com/intern/diff/D55941611/) ghstack-source-id: 221905285 Pull Request resolved: #123707
Since we have device generic torch.Event/Stream now, it is safe to replace _StreamBase/_Eventbase with torch.Stream/Event. - torch.cuda.Stream/torch.xpu/Stream won't need to inherit from _StreamBase - Alias is created between _StreamBase/_EventBase and torch.Stream/Event, because the dynamo is using them to trace stream and event. Differential Revision: [D55941611](https://our.internmc.facebook.com/intern/diff/D55941611/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55941611 |
egienvalue
added a commit
that referenced
this pull request
Apr 11, 2024
Pull Request resolved: #123707 Since we have device generic torch.Event/Stream now, it is safe to replace _StreamBase/_Eventbase with torch.Stream/Event. - torch.cuda.Stream/torch.xpu/Stream won't need to inherit from _StreamBase - Alias is created between _StreamBase/_EventBase and torch.Stream/Event, because the dynamo is using them to trace stream and event. ghstack-source-id: 221905285 @exported-using-ghexport Differential Revision: [D55941611](https://our.internmc.facebook.com/intern/diff/D55941611/)
Since we have device generic torch.Event/Stream now, it is safe to replace _StreamBase/_Eventbase with torch.Stream/Event. - torch.cuda.Stream/torch.xpu/Stream won't need to inherit from _StreamBase - Alias is created between _StreamBase/_EventBase and torch.Stream/Event, because the dynamo is using them to trace stream and event. Differential Revision: [D55941611](https://our.internmc.facebook.com/intern/diff/D55941611/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55941611 |
egienvalue
added a commit
that referenced
this pull request
Apr 12, 2024
Pull Request resolved: #123707 Since we have device generic torch.Event/Stream now, it is safe to replace _StreamBase/_Eventbase with torch.Stream/Event. - torch.cuda.Stream/torch.xpu/Stream won't need to inherit from _StreamBase - Alias is created between _StreamBase/_EventBase and torch.Stream/Event, because the dynamo is using them to trace stream and event. ghstack-source-id: 221905285 @exported-using-ghexport Differential Revision: [D55941611](https://our.internmc.facebook.com/intern/diff/D55941611/)
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
albanD
reviewed
Jun 20, 2024
Collaborator
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
Is this still needed? Or doesn't change much?
Contributor
Author
Oh, haven't got a chance to work on this. After we finish TorchRec side integration with torch.mtia.Stream, I will come back and finish this one. I will close it for now, will reopen it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Since we have device generic torch.Event/Stream now, it is safe to replace _StreamBase/_Eventbase with torch.Stream/Event.
Differential Revision: D55941611