Add test_cpp_extensions tests for stream_and_event and mita_backend #123614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the generic torch.Stream/Event with fake device gurad and hooks. ghstack-source-id: 221771109 @exported-using-ghexport Differential Revision: [D55902506](https://our.internmc.facebook.com/intern/diff/D55902506/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/123614
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f175c61 with merge base c5fafe9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Apr 9, 2024
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55902506 |
Test the generic torch.Stream/Event with fake device gurad and hooks. exported-using-ghexport Differential Revision: [D55902506](https://our.internmc.facebook.com/intern/diff/D55902506/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55902506 |
Test the generic torch.Stream/Event with fake device gurad and hooks. exported-using-ghexport Differential Revision: [D55902506](https://our.internmc.facebook.com/intern/diff/D55902506/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55902506 |
Test the generic torch.Stream/Event with fake device gurad and hooks. exported-using-ghexport Differential Revision: [D55902506](https://our.internmc.facebook.com/intern/diff/D55902506/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55902506 |
Test the generic torch.Stream/Event with fake device gurad and hooks. exported-using-ghexport Differential Revision: [D55902506](https://our.internmc.facebook.com/intern/diff/D55902506/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55902506 |
Test the generic torch.Stream/Event with fake device gurad and hooks. exported-using-ghexport Differential Revision: [D55902506](https://our.internmc.facebook.com/intern/diff/D55902506/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55902506 |
Test the generic torch.Stream/Event with fake device gurad and hooks. exported-using-ghexport Differential Revision: [D55902506](https://our.internmc.facebook.com/intern/diff/D55902506/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55902506 |
Test the generic torch.Stream/Event with fake device gurad and hooks. exported-using-ghexport Differential Revision: [D55902506](https://our.internmc.facebook.com/intern/diff/D55902506/) [ghstack-poisoned]
egienvalue
added a commit
that referenced
this pull request
Apr 25, 2024
ROCm CIs pick up two unrelated tests from #123614. Skip two tests if TEST_ROCm is true. cc jeffdaily sunway513 jithunnair-amd pruthvistony ROCmSupport dllehr-amd jataylo hongxiayang [ghstack-poisoned]
egienvalue
added a commit
that referenced
this pull request
Apr 25, 2024
ROCm CIs pick up two unrelated tests from #123614. Skip two tests if TEST_ROCm is true. cc jeffdaily sunway513 jithunnair-amd pruthvistony ROCmSupport dllehr-amd jataylo hongxiayang [ghstack-poisoned]
egienvalue
added a commit
that referenced
this pull request
Apr 25, 2024
ROCm CIs pick up two unrelated tests from #123614. Skip those two tests if TEST_ROCm is true and they shouldn't be run on ROCm since it loaded a fake device backend in the test. cc jeffdaily sunway513 jithunnair-amd pruthvistony ROCmSupport dllehr-amd jataylo hongxiayang [ghstack-poisoned]
pytorchmergebot
added a commit
that referenced
this pull request
Apr 25, 2024
…ackend (#123614)" This reverts commit 355dc34. Reverted #123614 on behalf of https://github.com/jeffdaily due to this PR broke ROCm with message RuntimeError: Cannot have MTIA with other devices ([comment](#123612 (comment)))
Collaborator
|
@egienvalue your PR has been successfully reverted. |
…a_backend" Test the generic torch.Stream/Event with fake device gurad and hooks. [ghstack-poisoned]
egienvalue
added a commit
that referenced
this pull request
Apr 25, 2024
Pull Request resolved: #123614 Test the generic torch.Stream/Event with fake device gurad and hooks. Since accelerator backends are mutual exclusive, tests will be skipped if TEST_CUDA or TEST_ROCM is true. @imported-using-ghimport Differential Revision: [D56443358](https://our.internmc.facebook.com/intern/diff/D56443358/) ghstack-source-id: a416973
alat-rights
pushed a commit
to alat-rights/pytorch
that referenced
this pull request
Apr 26, 2024
…ytorch#123614) Test the generic torch.Stream/Event with fake device gurad and hooks. Differential Revision: [D56443358](https://our.internmc.facebook.com/intern/diff/D56443358) Pull Request resolved: pytorch#123614 Approved by: https://github.com/albanD ghstack dependencies: pytorch#123611, pytorch#123612
Contributor
Author
|
I am relanding the PR. All ROCm signals look good. |
Contributor
Author
|
@pytorchmergebot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
petrex
pushed a commit
to petrex/pytorch
that referenced
this pull request
May 3, 2024
…ytorch#123614) Test the generic torch.Stream/Event with fake device gurad and hooks. @exported-using-ghexport Differential Revision: [D55902506](https://our.internmc.facebook.com/intern/diff/D55902506/) Pull Request resolved: pytorch#123614 Approved by: https://github.com/albanD ghstack dependencies: pytorch#123611, pytorch#123612
pytorch-bot bot
pushed a commit
that referenced
this pull request
May 3, 2024
…ackend (#123614)" This reverts commit b6f0159. Reverted #123614 on behalf of https://github.com/jeffdaily due to This broke ROCm. see test_overrides.py ([comment](#123611 (comment)))
pytorch-bot bot
pushed a commit
that referenced
this pull request
May 3, 2024
…123614) Test the generic torch.Stream/Event with fake device gurad and hooks. Differential Revision: [D56443358](https://our.internmc.facebook.com/intern/diff/D56443358) Pull Request resolved: #123614 Approved by: https://github.com/albanD ghstack dependencies: #123611, #123612
pytorch-bot bot
pushed a commit
that referenced
this pull request
May 3, 2024
…ackend (#123614)" This reverts commit 355dc34. Reverted #123614 on behalf of https://github.com/jeffdaily due to this PR broke ROCm with message RuntimeError: Cannot have MTIA with other devices ([comment](#123612 (comment)))
pytorch-bot bot
pushed a commit
that referenced
this pull request
May 3, 2024
…123614) Test the generic torch.Stream/Event with fake device gurad and hooks. Since we added a fake device backend, it is mutual exclusive to other backends. Tests will be skipped if TEST_CUDA or TEST_ROCM is true. Pull Request resolved: #123614 Approved by: https://github.com/albanD ghstack dependencies: #123611, #123612
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Test the generic torch.Stream/Event with fake device gurad and hooks. Since we added a fake device backend, it is mutual exclusive to other backends. Tests will be skipped if TEST_CUDA or TEST_ROCM is true.