Re-enable nightly testing for linux and macos binaries #123390
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/123390
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit e655f8c with merge base f7f018a ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
atalman
added
the
ciflow/binaries
| PYTORCH_ROOT: /pytorch | ||
| SHA1: ${{ github.event.pull_request.head.sha || github.sha }} | ||
| SKIP_ALL_TESTS: 1 | ||
| SKIP_ALL_TESTS: 0 |
There was a problem hiding this comment.
Hmm, I though that skip all tests is about buidling wheels without tests rather than not running nightly tests
Do you know when this change was made?
|
@pytorchmergebot rebase main |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchmergebot rebase -b main |
|
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
|
Successfully rebased |
pytorchmergebot
force-pushed
the
reenable_test
branch
from
35fd1c7 to
72695c1
Compare
|
@pytorchmergebot merge -f "All required tests are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Related to: #123225 The skip tests logic lives here: https://github.com/pytorch/builder/blob/main/run_tests.sh#L19 Linux builds are using check_binary: https://github.com/pytorch/pytorch/actions/runs/8627625694/job/23649245546#step:16:339 Pull Request resolved: #123390 Approved by: https://github.com/ZainRizvi
Added https://github.com/pytorch/builder/blob/c7564f31f7e1e5c8fab2f4ce511b2d73a3afbe60/wheel/build_wheel.sh to `.ci/wheel/` folder Commented out call to https://github.com/pytorch/builder/blob/39532891a083f0929d3b46f690a3ea719de6bf76/run_tests.sh, because since 2018 this script just checked that tests folder is there and exited, as there are no way to run all pytorch tests in single shard, see this logic: ```bash #!/bin/bash set -eux -o pipefail # Essentially runs pytorch/test/run_test.py, but keeps track of which tests to # skip in a centralized place. # # TODO Except for a few tests, this entire file is a giant TODO. Why are these # tests # failing? # TODO deal with Windows # This script expects to be in the pytorch root folder if [[ ! -d 'test' || ! -f 'test/run_test.py' ]]; then echo "builder/test.sh expects to be run from the Pytorch root directory " \ "but I'm actually in $(pwd)" exit 2 fi # Allow master skip of all tests if [[ -n "${SKIP_ALL_TESTS:-}" ]]; then exit 0 fi ``` #123390 is a misread attempt to interpret above-mentioned logic, as run_tests will be skipped if `${SKIP_ALL_TESTS}` is a non-empty string Pull Request resolved: #142277 Approved by: https://github.com/huydhn, https://github.com/atalman ghstack dependencies: #142276
4 participants
Related to: #123225
The skip tests logic lives here:
https://github.com/pytorch/builder/blob/main/run_tests.sh#L19
Linux builds are using check_binary:
https://github.com/pytorch/pytorch/actions/runs/8627625694/job/23649245546#step:16:339